Merge with sonic-buildimage from public master #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#### Why I did it The testcases in sonic-mgmt need the packages of protobuf and dashapi ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Because the docker of sonic-mgmt is based on ubuntu20.04, it cannot directly install the packages compiled by slave due to dependency issues. Download related packaged directly from Azp. #### How to verify it Check azp stats.
- Why I did it BIOS on new generation switch can come with a file type of cap or cab. Needs to add support to these file type. Also ONIE version on new devices can have a suffix of 'dev'. - How I did it Added cap & cab as possible component extensions for ComponentBIOS. Update the ONIE version regex to include dev signed versions. - How to verify it Update BIOS.
…et#15793) - Why I did it The reset cause "reset_from_comex" has been removed by hw-management, hence removing it from platform API code - How I did it Remove reset_from_comex from reboot cause mapping - How to verify it Manual test
= Why I did it To optimize Mellanox platform SAI build - How I did it SAI debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release. - How to verify it Configure/build for Mellanox platform, check the image and ensure that correct SAI debs are included.
…tem health (sonic-net#15289) - Why I did it Adjust PSU power threshold logic in system health. - How I did it Update the description message in PSU power threshold checking power of PSU x (xx w) exceeds threshold (xx w) => System power exceeds xx threshold (xx w) - How to verify it Manual test and unit test
…D automatically (sonic-net#15852) #### Why I did it src/sonic-platform-daemons ``` * 94242c2 - (HEAD -> master, origin/master, origin/HEAD) Use vendor customizable fan speed threshold checks (sonic-net#378) (3 hours ago) [spilkey-cisco] * db6e340 - Fix index out of range in the error log of invalid media lane mask received (sonic-net#386) (8 hours ago) [MichaelWangSmci] ``` #### How I did it #### How to verify it #### Description for the changelog
#### Why I did it Reduced root directory privileges #### How I did it During build_debian - called chroot to reduce root directory and its subdirectories privileges to 744 #### How to verify it After image build and upgrade - check /root privileges by calling "ls -a /root" #### Description for the changelog reduced /root directory privileges
…lly (sonic-net#15860) #### Why I did it src/sonic-swss ``` * 5b27c209 - (HEAD -> master, origin/master, origin/HEAD) Refactor Orch class to separate recorder implementation (sonic-net#2837) (8 hours ago) [Vivek] ``` #### How I did it #### How to verify it #### Description for the changelog
…face (sonic-net#15864) sonic-build image side change to fix source interface selection in dual tor scenario. dhcprelay related PR: [master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42 Announce dhcprelay submodule to 6a6ce24([to invoke #40 PR]([master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42))
Why I did it The protoc-dev isn't used by SONiC, but it was added to the derived package. Work item tracking Microsoft ADO (number only): 17417902 How I did it Remove protoc-dev from protobuf.mk Signed-off-by: Ze Gan <ganze718@gmail.com>
…tically (sonic-net#16004) #### Why I did it src/sonic-sairedis ``` * eb24302 - (HEAD -> master, origin/master, origin/HEAD) Build both the regular and RPC version when the RPC profile is enabled (sonic-net#1273) (28 hours ago) [Saikrishna Arcot] * 9e855c2 - [FEC] Adding support for vs testing for SAI_PORT_ATTR_AUTO_NEG_FEC_MODE_OVERRIDE (sonic-net#1271) (2 days ago) [Sudharsan Dhamal Gopalarathnam] * 4dbdb21 - Fix RPC package build failure due to shell syntax issue (sonic-net#1268) (10 days ago) [Saikrishna Arcot] * 588d596 - Make sure new binaries replace existing binaries in docker-sonic-vs (sonic-net#1269) (11 days ago) [Saikrishna Arcot] * ce8f642 - [vs] Use boost join to concatenate switch types in config (sonic-net#1266) (3 weeks ago) [Kamil Cudnik] * d6055a2 - [vslib]: Temporaily map DPU switch type to NVDA_MBF2H536C (sonic-net#1259) (4 weeks ago) [prabhataravind] * e1cdb4d - [CodeQL]: Use dependencies with relevant versions in azp template. (sonic-net#1262) (5 weeks ago) [Nazarii Hnydyn] * c08f9a2 - [CI]: Fix collect log error in azp template. (sonic-net#1260) (5 weeks ago) [Nazarii Hnydyn] * eed856c - [CodeQL]: Fix syncd compilation in azp template. (sonic-net#1261) (5 weeks ago) [Nazarii Hnydyn] * a3f1f1a - Reland 'Make changes to building and packaging sairedis (sonic-net#1116)' (sonic-net#1194) (6 weeks ago) [Saikrishna Arcot] ``` #### How I did it #### How to verify it #### Description for the changelog
Enable CPU watchdog on Celestica-E1031.
…atically (sonic-net#16123) #### Why I did it src/sonic-utilities ``` * 5b492d54 - (HEAD -> master, origin/master, origin/HEAD) [chassis][voq] clear: Fix clear queuecounters to also clear VOQ counters (sonic-net#2878) (2 days ago) [Patrick MacArthur] ``` #### How I did it #### How to verify it #### Description for the changelog
### Why I did it Since directories are being removed, the `-r` flag is required. Fixes sonic-net#15922 ##### Work item tracking - Microsoft ADO **(number only)**: 24752770
…S and S6301-56ST (sonic-net#16017) Why I did it Add PDDF support on following Ufispace platforms with Broadcom ASIC S9110-32X S8901-54XC S7801-54XS S6301-56ST How I did it Add PDDF configuration files, scripts and python files How to verify it Run pddf commands and show commands. Signed-off-by: nonodark <ef67891@yahoo.com.tw>
### Why I did it Background running lua script may cause redis-server quite busy if batch size is 8192. If handling time exceeded default 5s, the redis-server will not response to other process and will cause syncd crash. ``` Aug 9 07:46:29.512326 str-s6100-acs-5 INFO database#supervisord: redis 68:M 09 Aug 2023 07:46:29.511 # Lua slow script detected: still in execution after 5186 milliseconds. You can try killing the script using the SCRIPT KILL command. Script SHA1 is: 88270a7c5c90583e56425aca8af8a4b8c39fe757 Aug 9 07:46:29.523716 str-s6100-acs-5 ERR syncd#syncd: :- checkReplyType: Expected to get redis type 5 got type 6, err: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE. Aug 9 07:46:29.524818 str-s6100-acs-5 INFO syncd#supervisord: syncd terminate called after throwing an instance of ' Aug 9 07:46:29.525268 str-s6100-acs-5 ERR pmon#CCmisApi: :- checkReplyType: Expected to get redis type 5 got type 6, err: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE. Aug 9 07:46:29.526148 str-s6100-acs-5 INFO syncd#supervisord: syncd std::system_error' Aug 9 07:46:29.528308 str-s6100-acs-5 ERR pmon#psud[32]: :- checkReplyType: Expected to get redis type 5 got type 6, err: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE. Aug 9 07:46:29.529048 str-s6100-acs-5 ERR lldp#python3: :- guard: RedisReply catches system_error: command: *2#015#012$3#015#012DEL#015#012$27#015#012LLDP_ENTRY_TABLE:Ethernet37#015#012, reason: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.: Input/output error Aug 9 07:46:29.529720 str-s6100-acs-5 ERR snmp#python3: :- guard: RedisReply catches system_error: command: *2#015#012$7#015#012HGETALL#015#012$28#015#012COUNTERS:oid:0x100000000000a#015#012, reason: BUSY Redis is busy running a script. You can only call SCRIPT KILL or SHUTDOWN NOSAVE.: Input/output error ``` 88270a7c5c90583e56425aca8af8a4b8c39fe757 is /usr/share/swss/consumer_state_table_pops.lua ##### Work item tracking - Microsoft ADO **24741990**: #### How I did it Change batch size from 8192 to1024. #### How to verify it Run all test cases in sonic-mgmt to verify the system stability. ### Tested branch (Please provide the tested image version) - [x] 20220531.36
- Why I did it Update Mellanox MFT tool to version 4.25.0-62 - How I did it Update the MFT tool make file - How to verify it Run full sonic-mgmt regression. Signed-off-by: Kebo Liu <kebol@nvidia.com>
sonic-net#16096) SONiC changes: 1. Support Spectrum4 ASIC FW binary building. 2. Support new SDK sx-obj-desc lib building since new SAI need it. 3. Remove SX_SCEW debian package from Mellanox SDK build since we are no longer using it (we use libxml2 instead). 4. Update SAI, SDK, FW to version 4.6.1020/2012.1020/SAIBuild2305.25.0.3 SDK/FW bug fixes 1. In SPC-1 platforms: Fastboot mode is not operational for Split port with Force mode in 50G speed SFP modules are kept in disabled state after set LPM (low power mode) on/off for at least 3 minutes. 2. When preforming fast boot from an old SDK version (currently installed) to a newer one (target version), and the system was initially loaded with a new SDK version (past version), and the system has not been wiped, under specific conditions, the fast boot would use the past version's data and may fail. SDK/FW Features 1. On SN2700 all ports can support y cable by credo SAI bug Fixes 1. When creating an ACL rule with SAI_ACL_ENTRY_ATTR_FIELD_SRC_IP/SAI_ACL_ENTRY_ATTR_FIELD_DST_IP enabled, and then disabling the field by setting enable=false, a match on L3_type=IPv4 will remain programmed for the rule Issue resolved after the fix 2. Allow the max scale of virtual routers to be configure for SPC-1, SPC-2, SPC-3 when fastboot enable 3. Remove default hash key of SRC_MAC, DST_MAC and ETH_TYPE SAI features 1. Port init profile - How I did it Update SDK/FW/SAI make files - How to verify it Run full sonic-mgmt regression on Mellanox platform Signed-off-by: Kebo Liu <kebol@nvidia.com>
#### Why I did it Reduce docker privilege This is part of HLD sonic-net/SONiC#1364 #### How I did it Remove flag --privileged #### How to verify it docker exec -it database bash root@0048b82b460b:/# ip link add dummy0 type dummy RTNETLINK answers: Operation not permitted
#### Why I did it HLD implementation: Container Hardening (sonic-net/SONiC#1364) ##### Work item tracking - Microsoft ADO **(number only)**: 14807420 #### How I did it Reduce linux capabilities in privileged flag, retain NET_ADMIN capability
It appears that this was initially added to provide the git-retry command (which doesn't appear to be used today). However, this repo is now also providing bazel (which is actually used in our build today), and this command (along with git-retry) expects some vpython3 binary to be set up/installed. Rather than going through that, just get rid of this repo.
…5829) Signed-off-by: Mai Bui <maibui@microsoft.com>
…onic-net#16028) Why I did it Update the platform_reboot of Nokia Platform IXR-7250E-36x400G to displays the correct reboot-cause history when reboot from supervisor card. Work item tracking Microsoft ADO (number only): How I did it Modify the platform_reboot script to copy the correct reboo-cause.txt file from NDK to the /host/reboot-cause directory at the down cycle when the reboot is issued from Supervisor (for both reboot right after install a new image and normal reboot) Signed-off-by: mlok <marty.lok@nokia.com>
* sonic-buildimage: Add 7060DX5-64S brcm tunnel config Add bcm_tunnel_term_compatible_mode: 1 support, which allows Loopback configuration to no longer result in SAI failure "tunnel terminator add failed with error Feature unavailable" that caused Orchagent SIGABRT Signed-off-by: Aaron Payment <aaronp@arista.com> * sonic-buildimage: Set port config ENABLE:0 in 7060DX5-64S brcm config Set ENABLE:0 for the front panel ports in the brcm config so that the ports are default admin down. This change prevents the issue that ports are able to link up and pass traffic resulting in mac learn events after SAI create switch and before SAI admin state up. The unexpected mac learn events resulted in Orch agent crash in PortsOrch init, which occurs after SAI create switch and before SAI admin state up. * fix sensors.conf on CatalinaDD * Add support for two sfp ports * Add copper 50g tuning to babbagelp on catalina --------- Signed-off-by: Aaron Payment <aaronp@arista.com> Co-authored-by: enes.oncu <enes.oncu@arista.com> Co-authored-by: Boyang Yu <byu@arista.com>
…D_ONLY_CMDS in sudoers file (sonic-net#16115) Why I did it Few commands in multiasic platforms when run with the "sudo ip netns exec asic0 " option was taking like 15 mins to get the o/p. This behavior of sudo getting hung was seen by just doing this jujoseph@svcstr-server-2:~ sudo ip netns exec asic0 bash jujoseph@svcstr-server-2:~ sudo ls deally sudo is not needed as we have /bin/ip netns identify present in /etc/sudoers file. Hence removing it
GouthamBanala
approved these changes
Aug 21, 2023
renukamanavalan
pushed a commit
that referenced
this pull request
Oct 15, 2023
…face (sonic-net#15881) sonic-build image side change to fix source interface selection in dual tor scenario. dhcprelay related PR: [master]fix dhcpv6 relay dual tor source interface selection issue sonic-dhcp-relay#42 Announce dhcprelay submodule to 6a6ce24 to include PR #42
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just merge. No LoM changes.