-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use latest dependencies in pipeline image #239
Use latest dependencies in pipeline image #239
Conversation
…-image-to-use-latest-version-of-dependencies
…-image-to-use-latest-version-of-dependencies
Now that it seems you are updating the docker image. It could be added |
Sure, I can add it. I think these libraries are installed. I found no issue when enabling
Maybe I need Feel free to add any compilation flags you want on this branch @jgalan I will install required dependencies if there is a problem. |
…size on current Geant4 version
Apologizes, I did a small mesh, I will accept as soon as I fix that. Btw, do you know why |
Yes, its because of rest-for-physics/restG4#53, my guess is that some step limiters we are applying right now don't work on latest Geant4 versions and should be updated, however they give no errors. I think this should be fixable. I also removed the uploading of the related artifact since it takes too much time / space but will add it back once this is fixed. |
I agree, we can temporary avoid the upload of the artifacts till the issue is understood. |
Doesn't looks like the artifacts are skipped in the latest pipeline, will try to fix it |
I think ROOT validation files should never be modified/replaced. Perhaps adding new versions? |
Probably ROOT validation files could be placed at an independent repository, and the files could be made public in a http location. Such as it is done with https://sultan.unizar.es/axionlib-data/ and the repository https://github.com/rest-for-physics/axionlib-data. The http address is updated nightly in sultan through the Then, the validation pipeline could just get the validation file needed using |
I agree but I think for the time being this PR could be merged to fix the pipelines. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I approve just to fix the pipelines, by this PR with 2000 lines changes, renaming of validation ROOT files, probably replacement. It is too much, thus imposible to review.
Closes #238.
The latest official root image uses Ubuntu 22.04 as base so I think we should use it as a base too, instead of Ubuntu 20.04. There may be some problems due to this such as cmake version changes etc.
In this PR I renamed a few files in
pipeline/pandaxiii_MC
. I noticed one of the files used as reference to check simulation (originally namedvalidation.root
I think) was taking too much space, around 25MB but only its first 10 events were being used. I reduced it in size saving around 23MB of space, but we would need to remove big blobs from the history doing a force push in order to reduce the repository size.Related PR:
Part of this PR was merged in #248