Use latest dependencies in pipeline image #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for more statistics
juanangp
reviewed
Jun 13, 2022
| steps: | ||
| - name: Print version of dependencies for image | ||
| run: version.sh | ||
|
|
||
| - name: Checkout framework |
There was a problem hiding this comment.
For the build and installation of the framework, please consider to use .github/actions/build/action.yml from the framework branch.
This is not required in this PR, but we should avoid code duplication also in the workflows.
There was a problem hiding this comment.
Thanks, I will. Since in this case we only need to checkout a single submodule I think this way is more transparent.
juanangp
approved these changes
Jun 13, 2022
lobis
deleted the
238-update-pipeline-image-to-use-latest-version-of-dependencies
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to:
Using latest Geant4 versions (v11.0.2 at the time of writing).
I had to modify a few examples for them to pass, since we were doing some tests for specific events and choosing the same seed does not garantee the exact same outcome with different Geant4 versions.
I modified some of these examples to check for some average across all events, instead of checking for specific events. This way when we increase Geant4 version in the future we won't need to change this. I also updated the syntax to avoid using pointers etc. I added a tolerance instead of a exact number check, this helps avoid errors when working with real numbers, but the tolerance currently is 0.1% so its almost the same as checking exact values.
I also added better print during simulations. Now (on >= essential debug level) we get atleast 1% of events printed or atleast one event every 10 seconds, this way the user will not see a prompt without updates for long.
I discovered a bug preventing some values of metadata to be print on screen (rest-for-physics/geant4lib#53).
In this PR the tag of the image has been changed to
rest-for-physics-devinstead ofrest-for-physicsbut it will be moved back torest-for-physicsin a separate PR once that image is updated. The currentrest-for-physicsimage will be preserved frozen asrest-for-physics-reference-jun2022.Also I have found an issue #53 that makes examples ran with v11.0.2 generate too many tracks, but this surely can be fixed.
Regarding concenrs raised in rest-for-physics/framework#239 (comment) I have restructured the validation as follows:
restG4for the reference version of Geant4, in this case v10.4.3, then I run a few examples with validations adapted to this version, so we can know it still works as before for old version. I have only added two examples (01 and 07) to this but more could be added, altough I wouldn't add many since it clutters things a bit, I think this is enough.