Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): simplify insert nodes (probably the last crusade) #10232

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176, #9715, #9740, #9785, #10198.

This is also useful in the series of #10157

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ice1000 ice1000 enabled auto-merge June 8, 2023 06:15
@ice1000 ice1000 added this pull request to the merge queue Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #10232 (7497530) into main (6b4b4e6) will decrease coverage by 0.02%.
The diff coverage is 60.62%.

@@            Coverage Diff             @@
##             main   #10232      +/-   ##
==========================================
- Coverage   70.74%   70.72%   -0.02%     
==========================================
  Files        1236     1237       +1     
  Lines      211701   211710       +9     
==========================================
- Hits       149771   149742      -29     
- Misses      61930    61968      +38     
Flag Coverage Δ
rust 70.72% <60.62%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/generic/mod.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/plan_fragmenter.rs 67.57% <0.00%> (ø)
...c/frontend/src/optimizer/plan_node/batch_insert.rs 50.00% <40.00%> (+0.81%) ⬆️
...frontend/src/optimizer/plan_node/generic/delete.rs 80.00% <50.00%> (ø)
...frontend/src/optimizer/plan_node/generic/insert.rs 61.17% <61.17%> (ø)
...frontend/src/optimizer/plan_node/logical_insert.rs 61.76% <72.72%> (-23.07%) ⬇️
src/frontend/src/planner/insert.rs 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit abba437 Jun 8, 2023
@ice1000 ice1000 deleted the tesla/light branch June 8, 2023 06:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants