Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): simplify limit nodes (more likely to be the last crusade) #10246

Merged
merged 6 commits into from
Jun 8, 2023

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented Jun 8, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176, #9715, #9740, #9785, #10198, #10232.

This is also useful in the series of #10157

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 enabled auto-merge June 8, 2023 12:41
@ice1000 ice1000 added this pull request to the merge queue Jun 8, 2023
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #10246 (5757af9) into main (035aae7) will decrease coverage by 0.01%.
The diff coverage is 82.14%.

@@            Coverage Diff             @@
##             main   #10246      +/-   ##
==========================================
- Coverage   70.74%   70.73%   -0.01%     
==========================================
  Files        1237     1238       +1     
  Lines      211831   211849      +18     
==========================================
+ Hits       149851   149859       +8     
- Misses      61980    61990      +10     
Flag Coverage Δ
rust 70.73% <82.14%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/generic/mod.rs 0.00% <ø> (ø)
.../frontend/src/optimizer/plan_node/logical_dedup.rs 89.47% <50.00%> (ø)
.../frontend/src/optimizer/plan_node/generic/limit.rs 75.00% <75.00%> (ø)
.../frontend/src/optimizer/plan_node/logical_limit.rs 59.01% <80.00%> (-11.26%) ⬇️
...rc/frontend/src/optimizer/plan_node/batch_limit.rs 70.00% <85.71%> (-2.73%) ⬇️
src/frontend/src/optimizer/plan_node/batch_topn.rs 82.45% <100.00%> (ø)
.../frontend/src/optimizer/plan_node/generic/top_n.rs 87.89% <100.00%> (ø)
...c/frontend/src/optimizer/plan_node/logical_topn.rs 97.03% <100.00%> (ø)
...ntend/src/optimizer/plan_node/stream_group_topn.rs 98.18% <100.00%> (ø)
...rc/frontend/src/optimizer/plan_node/stream_topn.rs 95.08% <100.00%> (ø)
... and 1 more

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Merged via the queue into main with commit ab86af8 Jun 8, 2023
@ice1000 ice1000 deleted the tesla/marisa branch June 8, 2023 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants