Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plan_node): use generics in update nodes #9740

Merged
merged 5 commits into from
May 10, 2023
Merged

Conversation

ice1000
Copy link
Contributor

@ice1000 ice1000 commented May 10, 2023

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Follow up of #8898, #8870, #8905, #8930, #8932, #9011, #9044, #9176, #9715.
This PR simplifies batch-update nodes.

Checklist For Contributors

  • Yes

Documentation

  • My PR DOES NOT contain user-facing changes.

@ice1000 ice1000 requested a review from st1page May 10, 2023 14:40
@ice1000 ice1000 enabled auto-merge May 10, 2023 14:41
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 3410 files.

Valid Invalid Ignored Fixed
1552 1 1857 0
Click to see the invalid file list
  • src/frontend/src/optimizer/plan_node/generic/update.rs

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #9740 (b342961) into main (e6dc622) will decrease coverage by 0.01%.
The diff coverage is 85.33%.

@@            Coverage Diff             @@
##             main    #9740      +/-   ##
==========================================
- Coverage   70.98%   70.97%   -0.01%     
==========================================
  Files        1245     1246       +1     
  Lines      208369   208350      -19     
==========================================
- Hits       147909   147875      -34     
- Misses      60460    60475      +15     
Flag Coverage Δ
rust 70.97% <85.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/frontend/src/optimizer/plan_node/generic/mod.rs 0.00% <ø> (ø)
src/frontend/src/scheduler/plan_fragmenter.rs 67.57% <0.00%> (ø)
...c/frontend/src/optimizer/plan_node/batch_update.rs 68.00% <71.42%> (-4.42%) ⬇️
...frontend/src/optimizer/plan_node/logical_update.rs 58.20% <72.72%> (-22.50%) ⬇️
...frontend/src/optimizer/plan_node/generic/update.rs 100.00% <100.00%> (ø)
src/frontend/src/planner/update.rs 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants