Split tests into dedicated test packages #455
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthew-reynolds
changed the title
Comment on lines
+32
to
+33
| <!-- <test_depend>gazebo</test_depend> --> | ||
| <!-- <test_depend>gazebo_worlds</test_depend> --> |
There was a problem hiding this comment.
Note that these two deps are commented since they have not existed since Hydro, but are used in view_diffbot.launch and view_skidsteerbot.launch.
Once those two files are deleted as part of my follow-up cleanup, these deps will be deleted as well. Same goes for all of the excessive <test_depends> throughout this PR (rqt_plot, rviz, etc.) - All will be deleted once the tests using them are deleted in my follow-up.
matthew-reynolds
force-pushed
the
separate-tests
branch
from
908dae6
to
8c2f709
Compare
|
This PR also resolves #378 |
|
@ipa-mdl do you have any comments regarding this? |
|
I would not split the tests..
If I recall it correctly, these "unused" files are meant to be used for local (non-CI) tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #453
This PR attempts to be as minimal as possible. As much as possible, I only moved code, avoiding changing/adding anything else. The main exception is updating and adding all the required dependencies to the new test packages. Note that, in some cases, these dependencies are somewhat excessive (See follow-up 1) - My goal is to simply match deps to what's currently in the tests, cleanup will come later.
Related follow up PRs I'm working on:
rviz,rqt_plot, and in some cases old Hydro-era packages likegazeboandgazebo_worlds)