Add TCP_INFO availability check #1211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the quick fix. @Yay295 can you please try this patch and comment if it works around the problem you have with WSL. |
|
Unfortunately not. This isn't a Python problem, so |
|
@Yay295 Can you please propose a PR with a patch which works for you. |
otamachan
force-pushed
the
check_TCP_INFO
branch
from
f2ede6d to
9c2365d
Compare
|
Thank you for the patch. I changed the logic in e5112a7 in order to simplify the diff. |
dirk-thomas
pushed a commit
that referenced
this pull request
Feb 9, 2018
* Add TCP_INFO availability check * simplify diff / patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As using
TCP_INFOis not a portable code (#1207), check its availability before using.