changes between 1.12.12 and 1.13.6 for backporting #1323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* not imply that spinning was successful when mixing single threaded spinner with multi/async spinners * updated error messages to reflect behavior when calling a singlethreaded spinner alongside a multithreaded one
I added some sys.exit(1)'s to rosbag commands to help with scripting. Specifically, I expected a call to `rosbag info test.bag.active` to return an error when the bag needed re-indexing.
* Performance improvement for lower/upper bound Changed updateQueries() to use member functions of `multiset` instead of `std::lower_bound` and `std::upper_bound` * Fixed warnings for C++98 Changed the calls to lower/upper bounds so they dont use the "new" C++11 extended initializer lists.
Switching to using epoll system calls to improve performance of the topic polling code by a factor of 2. This required disabling the addDelMultiThread test.
* adding decompress to free(state) before return * copy paste typo error on roslz4_decompressEnd * revert unnecessary change
Previously, this was causing `TypeError: 'module' object is not callable`, which was not noticed due to the bare `except:` in the test.
* Add TCP_INFO availability check * simplify diff / patch
* Add add_rostest_gmock function * Increase catkin required version due to new GMock API
Address a long standing issue where the `sockets_changed_` flag would never be reset causing the native poll set to be re-created everytime doing a poll.
When a process on a remote machine dies, the `process_died` callback of the server is called. However, the process listeners given to `ROSLaunchParent` need to be forwarded to the server, otherwise they cannot be called.
* fix xmlrpc timeout using monotonic clock in XmlRpcDispatch::work the _endTime check was using system time instead of monotonic time, so when time was set back it didn't process all events.. * replace clock_gettime for OSX * xmlrpcpp: copy code from ros_steadytime for getTime * use ros_steadytime which depends on ros/roscpp_core#73 and assumes that it will be available with rostime 0.6.9 * fold build and run depend into depend tag to avoid version to be repeated * add missing namespace to ros_steadytime * add missing target_link_libraries * add missing lib to tests
|
For now #1249 was not included yet since it requires a release of |
wjwwood
approved these changes
Feb 10, 2018
|
@wjwwood Thank you for your feedback. The latest Lunar release has just been synced. I will wait until early next week until I merge and release this into Kinetic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following list of changes has been integrated into
ros_comm1.13.6 (Lunar) since the last Kinetic release (1.12.12).Backported: (these changes are part of this PR)
fix warn of --max-splits without --split Fixed warn of --max-splits without --split #1237
fix documentation for cleanup_master_blacklist() Fixed documentation for cleanup_master_blacklist() #1253
change error message for single threaded spinner changed error message for single threaded spinner #1164
make xmlrpcpp specific include directory work in devel space make xmlrpcpp specific include directory work in devel space #1261
return an error status on error in rosbag return an error status on error in rosbag #1257
replaced deprecated syntax using backticks Replaced deprecated syntax (backticks with repr()). #1259
performance improvement for lower/upper bound Performance improvement for lower/upper bound #1223
monotonic clock for callback queue timeouts monotonic clock for callback queue timeouts #1250
topic subscription scalability fix in Topic subscription scalability fix #1217
fix bad IPv6 initialization order Fixes #1262 - bad IPv6 initialization order. #1268
fix incorrect docstrings in
rosnode/__init__.pyFixed incorrect docstrings in rosnode/__init__.py #1278add decompress to free(state) before return adding decompress to free(state) before return (targeting Lunar) #1313
raise the correct exception from AnyMsg.serialize Raise the correct exception from AnyMsg.serialize #1311
make master process explicitly 'required' for parent launch Make master process explicitly 'required' for parent launch #1228
add TCP_INFO availability check Add TCP_INFO availability check #1211
add add_rostest_gmock function Add add_rostest_gmock function #1303
topic subscription scalability fix in Topic subscription scalability fix #1281
add process listeners to XML RPC server add process listeners to XML RPC server #1319
fix xmlrpc timeout using monotonic clock fix xmlrpc timeout using monotonic clock #1249
Not backported:
tests for XmlRpcValue and XML conversion Tests for XmlRpcValue and XML conversion. #1216
unit tests and bug fixes for XmlRpcSocket Unit tests and bug fixes for XmlRpcSocket #1218
fix error handling Fix for (#1224) #1226
unit tests and bug fixes for XmlRpcClient Unit tests and bug fixes for XmlRpcClient #1221
unit tests for XmlRpcDispatch Unit tests for XmlRpcDispatch #1232
update lz4 function name to support Trusty Enable Trusty support for lunar-devel #1236
use namespaced macros instead of deprecated macros use namespaced macros instead of deprecated macros #1239
base64 tests Base64 tests #1242
remove unnecessary xmlrpcpp dependency from message_filters Remove unnecessary xmlrpcpp dependency from message_filters #1264
test and fix uninitialized data in XmlRpcClient Test and fix uninitialized data in XmlRpcClient #1244
tests and bug fixes for XmlRpcServer Tests and bug fixes for XmlRpcServer #1243
add parameter to omit topics list from rosout logs added parameter to omit topics list from rosout logs #1234
use roslaunch.core.printerrlog for printing error message [roslaunch-check] Use roslaunch.core.printerrlog for printing error message. #1193
use SteadyTimer in message_filters use SteadyTimer in message_filters #1247
replace Thread.setDaemon() using new API Replaced Thread.setDaemon() using new API. #1276
remove unreachable exceptions Removed unreachable exceptions. #1260
printerrlog does not have file keyword printerrlog does not have file keyword #1317
add --tcpnodelay TransportHint option to hz and delay commands rostopic: Add --tcpnodelay TransportHint option to hz and delay commands #1296
fix search strategy for python_logging config Fixed search strategy for python_logging config #1292
rename log macro argument from rate to period rename log macro argument from rate to period #1318
remove preprended '|' from pretty-printed strings Remove preprended '|' from pretty-printed strings #1114
pass through command-line args to the xmlloader when using the API roslaunch - pass through command-line args to the xmlloader when using the API #1115
@ros/ros_team @ros/ros_comm-maintainers Please comment on the decision which changes to (not) backport. Especially look at the changes marked with a "?".