Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise the correct exception from AnyMsg.serialize #1311

Merged
merged 1 commit into from
Feb 1, 2018

Conversation

drigz
Copy link
Contributor

@drigz drigz commented Jan 19, 2018

Previously, this was causing TypeError: 'module' object is not callable, which was not noticed due to the bare except: in the test.

I wasn't able to run the tests, so I'm relying on CI to test that part of the change. I tried running them within a ros:lunar docker container with:

catkin_make --pkg ros_comm
catkin_make run_tests_test_rospy_rostest

but got lots of errors like:

  File "/catkin_ws/src/ros_comm/clients/rospy/src/rospy/client.py", line 68, in <module>
    from roscpp.srv import GetLoggers, GetLoggersResponse, SetLoggerLevel, SetLoggerLevelResponse
ImportError: No module named srv

Previously, this was causing `TypeError: 'module' object is not
callable`, which was not noticed due to the bare `except:` in the test.
@dirk-thomas
Copy link
Member

Thank you for the patch.

In the future please see the buildfarm documentation on how to reproduce the same build locally: https://github.com/ros-infrastructure/ros_buildfarm/blob/master/doc/jobs/devel_jobs.rst#run-the-devel-job-locally

@dirk-thomas dirk-thomas added the bug label Feb 1, 2018
@dirk-thomas dirk-thomas merged commit 6051daa into ros:lunar-devel Feb 1, 2018
dirk-thomas pushed a commit that referenced this pull request Feb 9, 2018
Previously, this was causing `TypeError: 'module' object is not
callable`, which was not noticed due to the bare `except:` in the test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants