rostopic: repeatedly republish message from file #1635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hm, looks like the build-infastructure had an hiccup ... |
|
@ros-pull-request-builder retest this please |
dirk-thomas
reviewed
Mar 1, 2019
| if exactly_one_message: | ||
| exactly_one_message = False | ||
| break | ||
| exactly_one_message = True |
There was a problem hiding this comment.
Doesn't this alter the content returned by the iterator in the later loop - in the case of the iterator being stdin_yaml_arg?
There was a problem hiding this comment.
Yes, that's right. The fix makes not much sense for stdin stream anyway, so I limited it to actual files now.
|
flaky tests again... |
|
@ros-pull-request-builder retest this please |
|
Thanks for the patch and for iterating on it. Ignoring the flaky test on CI... |
This was referenced Mar 9, 2019
tahsinkose
pushed a commit
to tahsinkose/ros_comm
that referenced
this pull request
Apr 15, 2019
* rostopic: repeatedly republish message from file * rostopic pub: limit 'exactly one message'-fix to real files, not streams
|
substitute_keywords argument isn't used in this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces #1348