Make test_tracetools ping pubs/subs transient_local #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make sure that the initial `/ping` message is received no matter the launch order of the `*ping` and `*pong` executables. Also, given this guarantee, cancel the timer after the initial `/ping` message. Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
|
Once this is approved, I'll trigger CI and will use |
|
Or let's just do it now:
|
fujitatomoya
approved these changes
Jul 4, 2024
|
Alright, then let's go ahead with this. This way we'll have the long weekend to see if it works. |
christophebedard
deleted the
christophebedard/ping-pong-tracing-tests-use-transient-local-stability
branch
|
@Mergifyio backport jazzy |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Aug 22, 2024
This will make sure that the initial `/ping` message is received no matter the launch order of the `*ping` and `*pong` executables. Also, given this guarantee, cancel the timer after the initial `/ping` message. Finally, add some helpful debug logs. Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai> (cherry picked from commit 00a4e99)
christophebedard
added a commit
that referenced
this pull request
Aug 26, 2024
This will make sure that the initial `/ping` message is received no matter the launch order of the `*ping` and `*pong` executables. Also, given this guarantee, cancel the timer after the initial `/ping` message. Finally, add some helpful debug logs. Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai> (cherry picked from commit 00a4e99) Co-authored-by: Christophe Bedard <christophe.bedard@apex.ai>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #124
See an overview of the tests in #124 (comment)
This will make sure that the initial
/pingmessage is received no matter the launch order of the*pingand*pongexecutables.Also, given this guarantee, cancel the timer after the initial
/pingmessage.Finally, add some helpful debug logs.