Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run relevant test_tracetools tests with all instrumented rmw impls #134

Merged
merged 1 commit into from
Aug 26, 2024
Merged

Run relevant test_tracetools tests with all instrumented rmw impls #134

merged 1 commit into from
Aug 26, 2024

Conversation

christophebedard
Copy link
Member

@christophebedard christophebedard commented Aug 22, 2024 •
edited
Loading

Fixes #131

This is equivalent similar to #116 but for Jazzy.

See explanation in #132. For Jazzy, rmw_connextdds is supported (compared to Iron), but rmw_fastrtps_dynamic_cpp is not (compared to Rolling).

@christophebedard christophebedard self-assigned this Aug 22, 2024
@christophebedard christophebedard force-pushed the christophebedard/jazzy-skip-test-tracetools-tests-uninstrumented-rmw branch from da1039d to 83c0a26 Compare August 22, 2024 21:26
@christophebedard
Copy link
Member Author

I don't think we have a manual version of the Jci__nightly-fastrtps-dynamic_ubuntu_noble_amd64 job, so I'll just run manual CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

I did test locally by setting RMW_IMPLEMENTATIONS=rmw_fastrtps_dynamic_cpp when running colcon build and the tests were skipped.

@christophebedard
Copy link
Member Author

christophebedard commented Aug 22, 2024 •
edited
Loading

I think the failure in test_pub_sub__rmw_connextdds on RHEL is a flake and should be resolved by backporting #125 to Jazzy: #135.

@christophebedard
Run relevant test_tracetools tests with all instrumented rmw impls
deef761 
This is equivalent to #116 but for Jazzy.

Signed-off-by: Christophe Bedard <christophe.bedard@apex.ai>
@christophebedard christophebedard force-pushed the christophebedard/jazzy-skip-test-tracetools-tests-uninstrumented-rmw branch from 83c0a26 to deef761 Compare August 26, 2024 17:55
@christophebedard
Copy link
Member Author

I think the failure in test_pub_sub__rmw_connextdds on RHEL is a flake and should be resolved by backporting #125 to Jazzy: #135.

Done. I rebased this. Re-running CI just to be sure:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Linux-rhel Build Status
  • Windows Build Status

@christophebedard
Copy link
Member Author

christophebedard commented Aug 26, 2024 •
edited
Loading

@clalancette @fujitatomoya can one of you review this?

The new CMake warnings in the ci_linux-rhel job above seem unrelated.

@christophebedard christophebedard merged commit 7515dd3 into jazzy Aug 26, 2024
9 checks passed
@christophebedard christophebedard deleted the christophebedard/jazzy-skip-test-tracetools-tests-uninstrumented-rmw branch August 26, 2024 22:06
@christophebedard christophebedard mentioned this pull request Aug 26, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@fujitatomoya fujitatomoya Awaiting requested review from fujitatomoya

Assignees

@christophebedard christophebedard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophebedard @clalancette