Remove ready_fn, self.proc_info #376

pbaughman · 2019-10-22T18:09:39Z

The ready_fn will be deprecated in the future in favor of the ReadyToTest() action in launch_testing. See ros2/launch#346 (comment) for background information

Signed-off-by: Pete Baughman pete.baughman@apex.ai

sloretz · 2019-10-22T21:57:11Z

@pbaughman it looks like there's a merge conflict. Would you mind rebasing this one?

pbaughman · 2019-10-22T22:08:57Z

@sloretz Yeah, I'll probably need to update some more tests, too. I think the MR causing the conflict added some new stuff as well

sloretz · 2019-10-22T23:39:32Z

CI (Testing ros2action ros2interface ros2msg ros2node ros2pkg ros2service ros2srv ros2topic)

Linux
Linux-aarch64
macOS
Windows

sloretz · 2019-10-23T00:20:08Z

@pbaughman Looks like there are 4 test failures with the same message. Mind taking a look?

Exception: generate_test_description functions without a ready_fn argument must return a LaunchDescription containing a ReadyToTest action

pbaughman · 2019-10-23T01:15:03Z

@sloretz Yeah - sorry - the required changes to launch_testing weren't in the nightly docker image yet, and then I put this down and forgot about it in the middle of adding launch to the workspace. I'll get it working first thing tomorrow

pbaughman · 2019-10-23T15:41:32Z

@sloretz This looks like a bug/not implemented thing in launch.actions.ExecuteProcess. The ExecuteProcess action isn't returning any sub-entities, so launch_testing can't discover the ReadyToTest action.

I'll need to address that in launch before we can move ahead with this. Edit ros2/launch#347

pbaughman · 2019-11-18T17:23:09Z

@sloretz I think that @hidmic fixed the issue we were running into in launch_testing here

I noticed that one more test was added that did things the 'old' way. I've rebased this branch and updated the new test. Can we try to run this through CI again?

pbaughman · 2019-11-18T23:15:54Z

Looks like something is still a little wrong

09:23:17 ============================= test session starts ==============================
09:23:17 platform linux -- Python 3.6.8, pytest-3.3.2, py-1.5.2, pluggy-0.6.0
09:23:17 rootdir: /tmp/ws/src/ros2cli/ros2topic, inifile:
09:23:17 plugins: launch-testing-0.9.5, launch-testing-ros-0.9.3, ament-xmllint-0.8.1, ament-pep257-0.8.1, ament-lint-0.8.1, ament-flake8-0.8.1, ament-copyright-0.8.1, cov-2.5.1
09:23:17 collected 8 items
09:23:17 
09:24:02 test/test_cli.py .                                                       [ 12%]
09:24:02 test/test_copyright.py .                                                 [ 25%]
09:24:17 test/test_echo_pub.py F                                                  [ 37%]
09:24:18 test/test_flake8.py .                                                    [ 50%]
09:24:19 test/test_info.py .                                                      [ 62%]
09:24:19 test/test_pep257.py .                                                    [ 75%]
09:24:19 test/test_qos_conversions.py .                                           [ 87%]
09:24:19 test/test_xmllint.py .                                                   [100%]
09:24:19 
09:24:19 -------- generated xml file: /tmp/ws/test_results/ros2topic/pytest.xml ---------
09:24:19 =================================== FAILURES ===================================
09:24:19 _________________________ launch tests: test_echo_pub __________________________
09:24:19 some test cases have failed:
09:24:19 
09:24:19 ----------------------------- Captured stdout call -----------------------------
09:24:19 [INFO] [launch]: All log files can be found below /home/buildfarm/.ros/log/2019-11-18-09-23-17-682477-f87f49776edc-3095
09:24:19 [INFO] [launch]: Default logging verbosity is set to INFO
09:24:19 [INFO] [daemon-stop-35]: process started with pid [3299]
09:24:19 [INFO] [daemon-stop-35]: process has finished cleanly [pid 3299]
09:24:19 [INFO] [daemon-start-36]: process started with pid [3302]
09:24:19 [INFO] [daemon-start-36]: process has finished cleanly [pid 3302]
09:24:19 Timed out waiting for processes to start up
09:24:19 Processes under test stopped before tests completed
09:24:19 ===================== 1 failed, 7 passed in 61.80 seconds ======================
09:24:19

pbaughman · 2020-01-25T17:12:04Z

@sloretz I think this is good to go after rebasing. Can you run CI? I don't get any ros2topic failures when I run the tests locally on 'master' and on my branch.

I do see failures in ros2actions but those happen for me in 'master'

pbaughman · 2020-02-03T17:33:22Z

@sloretz Can you re-run CI on this? I don't see any failure in this branch that aren't already in 'master'

pbaughman · 2020-02-06T18:42:19Z

@sloretz Sorry to keep bugging you, but poke ^^

sloretz · 2020-02-06T19:02:21Z

CI (Testing ros2action ros2interface ros2msg ros2node ros2pkg ros2service ros2srv ros2topic)

Linux
Linux-aarch64
macOS edit: cancelled in queue
Windows
Windows-container

pbaughman · 2020-02-06T20:57:26Z

@sloretz Looks like something with the build failed?

11:03:07 Package 'ros2msg' specified with --packages-up-to was not found
11:03:07 Package 'ros2srv' specified with --packages-up-to was not found

It doesn't look like it even made it to the 'test' step I'm guessing these packages were renamed or something on 'master'

I rebased the branch again

sloretz · 2020-02-06T21:32:28Z

It doesn't look like it even made it to the 'test' step I'm guessing these packages were renamed or something on 'master'

Ah oops. I copy pasted the args I used last time, but it looks like those were deleted in #407.

CI (Testing ros2action ros2interface ros2node ros2pkg ros2service ros2topic)

Linux
Linux-aarch64
macOS
Windows
Windows-container edit: java backtrace, jenkins issue

pbaughman · 2020-02-14T23:00:22Z

@sloretz I'm pretty sure this is a bad test that tries to assert about the fibonacci_action_server.py process before it's started up. Should I open a different PR that attempts to fix the test, or should I try to glom it onto this branch?

@hidmic Just FYI if you're seeing similar problems on other similar tests ^^

pbaughman · 2020-02-15T00:32:45Z

I'll need to fix ros2/launch#381 before I can fix this test. I want to add a stdout_ready_listener to delay the start of the test until the fibonacci_action_server.py process is started up, but I can't because event_handler introspection appears to be broken right now

pbaughman · 2020-02-18T21:00:02Z

Waiting on ros2/launch#386 so I can delay the start of the tests until after the Fibonacci action server is up-and-running

pbaughman · 2020-02-28T01:02:18Z

@sloretz Ok, #459 should've hopefully fix the test that was causing us problems. Can we try CI again (for the billionth time, I'm so sorry 😢 )

pbaughman · 2020-03-03T17:19:37Z

@sloretz ping^^

sloretz · 2020-03-05T01:47:32Z

CI (Testing ros2action ros2interface ros2node ros2pkg ros2service ros2topic) 🤞

Linux
Linux-aarch64
macOS
Windows

pbaughman · 2020-03-05T02:33:25Z

This looks unrelated to my changes again. . .

17:55:30     from rmw_implementation import get_available_rmw_implementations
17:55:30 E   ModuleNotFoundError: No module named 'rmw_implementation'

I'll try rebasing again I guess.

pbaughman · 2020-03-05T02:38:15Z

@sloretz Yeah, 96cf5b9 changed this yesterday and I pushed to this branch five days ago so it broke out from under me. Please run it again I guess. I'm going to be so happy when this PR is gone forever.

Side topic - Should I just log in every day and rebase this branch while I'm waiting for someone to run CI? This is not the first time that it's gotten broken out from under me. How can I make faster progress here?

sloretz · 2020-03-05T15:31:30Z

CI (Testing ros2action ros2interface ros2node ros2pkg ros2service ros2topic)

~~Linux~~
~~Linux-aarch64~~
~~macOS~~
~~Windows~~ edit: Ignore, wrong args

I'm going to be so happy when this PR is gone forever.

Thank you for sticking with it!

Should I just log in every day and rebase this branch while I'm waiting for someone to run CI? This is not the first time that it's gotten broken out from under me. How can I make faster progress here?

Rebasing frequently helps. That works around ci.ros2.org being incapable of merging forks into the target branch and then building/testing.

sloretz · 2020-03-05T18:22:46Z

Gah, Wrong parameters CI again

Linux
Linux-aarch64
macOS
Windows

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>

pbaughman · 2020-03-06T03:05:33Z

@sloretz Still looks like upstream issues with the build. It didn't even make it to the tests:

--- output: sqlite3_vendor
14:27:15 [0.045s] CMake Error: The source directory "/home/jenkins-agent/workspace/ci_linux/ws/build/sqlite3_vendor/rosbag2" does not exist.
14:27:15 [0.045s] Specify --help for usage, or press the help button on the CMake GUI.
14:27:15 [0.045s] Not searching for unused variables given on the command line.
14:27:15 ---
14:27:15 Aborted  <<< sqlite3_vendor

No idea what's been going on with sqllite3_vendor or rosbag2. Gonna rebase again?

jacobperron · 2020-03-06T21:38:09Z

The CI jobs linked do not look like the correct ones.

sloretz · 2020-03-06T21:41:09Z

The CI jobs linked do not look like the correct ones.

Good catch. It looks like the jobs were queue'd, but some earlier in the queue got aborted so the real job numbers didn't match. I've fixed the links in the comment above. @pbaughman FYI

jacobperron · 2020-03-06T21:44:12Z

The failures using CycloneDDS is a known issue: #457

jacobperron · 2020-03-06T21:49:22Z

Connext failures also appear, sometimes, on the nightlies (for example).

jacobperron

LGTM

pbaughman · 2020-03-06T21:50:41Z

The failures using CycloneDDS is a known issue: #457

It looks like all the failures in ros2service.test.test_cli.test_cli, ros2node.test.test_cli.test_cli, and ros2action.test.test_cli.test_cli were cyclone DDS failures.

The connext failures seem like they're only in ros2topic.test.test_cli.test_cli

jacobperron · 2020-03-06T21:52:41Z

@sloretz I'll defer to you for merging this.

sloretz · 2020-03-06T22:16:36Z

Thanks for the PR and for sticking with it @pbaughman !

pbaughman mentioned this pull request Oct 22, 2019

Warn that old-style ready_fn and test attributes will be deprecated ros2/launch#346

Merged

pbaughman force-pushed the remove_deprecated_features branch from 169b864 to c61418e Compare October 22, 2019 22:22

pbaughman force-pushed the remove_deprecated_features branch from c61418e to e19e062 Compare November 18, 2019 17:19

pbaughman force-pushed the remove_deprecated_features branch 2 times, most recently from 1d6ff41 to 69d4e16 Compare January 25, 2020 17:10

pbaughman force-pushed the remove_deprecated_features branch from 69d4e16 to 002ef31 Compare February 6, 2020 20:56

pbaughman force-pushed the remove_deprecated_features branch from 002ef31 to d2eed85 Compare February 20, 2020 16:43

pbaughman mentioned this pull request Feb 20, 2020

Fix race in ros2action test_cli #454

Closed

pbaughman force-pushed the remove_deprecated_features branch from d2eed85 to 3be5c40 Compare February 28, 2020 01:01

pbaughman force-pushed the remove_deprecated_features branch from 3be5c40 to 50f40fa Compare March 5, 2020 02:37

Remove ready_fn from test descriptions

dee3739

Signed-off-by: Pete Baughman <pete.baughman@apex.ai>

pbaughman force-pushed the remove_deprecated_features branch from 50f40fa to dee3739 Compare March 6, 2020 03:05

jacobperron approved these changes Mar 6, 2020

View reviewed changes

sloretz approved these changes Mar 6, 2020

View reviewed changes

sloretz merged commit af44e53 into ros2:master Mar 6, 2020

pbaughman deleted the remove_deprecated_features branch March 6, 2020 22:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ready_fn, self.proc_info #376

Remove ready_fn, self.proc_info #376

pbaughman commented Oct 22, 2019

sloretz commented Oct 22, 2019

pbaughman commented Oct 22, 2019

sloretz commented Oct 22, 2019

sloretz commented Oct 23, 2019

pbaughman commented Oct 23, 2019

pbaughman commented Oct 23, 2019 •

edited

Loading

pbaughman commented Nov 18, 2019

pbaughman commented Nov 18, 2019

pbaughman commented Jan 25, 2020

pbaughman commented Feb 3, 2020

pbaughman commented Feb 6, 2020 •

edited

Loading

sloretz commented Feb 6, 2020 •

edited

Loading

pbaughman commented Feb 6, 2020

sloretz commented Feb 6, 2020 •

edited

Loading

pbaughman commented Feb 14, 2020

pbaughman commented Feb 15, 2020

pbaughman commented Feb 18, 2020

pbaughman commented Feb 28, 2020 •

edited

Loading

pbaughman commented Mar 3, 2020

sloretz commented Mar 5, 2020

pbaughman commented Mar 5, 2020

pbaughman commented Mar 5, 2020 •

edited

Loading

sloretz commented Mar 5, 2020 •

edited

Loading

sloretz commented Mar 5, 2020 •

edited

Loading

pbaughman commented Mar 6, 2020

jacobperron commented Mar 6, 2020

sloretz commented Mar 6, 2020

jacobperron commented Mar 6, 2020

jacobperron commented Mar 6, 2020

jacobperron left a comment

pbaughman commented Mar 6, 2020 •

edited

Loading

jacobperron commented Mar 6, 2020

sloretz commented Mar 6, 2020

Remove ready_fn, self.proc_info #376

Remove ready_fn, self.proc_info #376

Conversation

pbaughman commented Oct 22, 2019

sloretz commented Oct 22, 2019

pbaughman commented Oct 22, 2019

sloretz commented Oct 22, 2019

sloretz commented Oct 23, 2019

pbaughman commented Oct 23, 2019

pbaughman commented Oct 23, 2019 • edited Loading

pbaughman commented Nov 18, 2019

pbaughman commented Nov 18, 2019

pbaughman commented Jan 25, 2020

pbaughman commented Feb 3, 2020

pbaughman commented Feb 6, 2020 • edited Loading

sloretz commented Feb 6, 2020 • edited Loading

pbaughman commented Feb 6, 2020

sloretz commented Feb 6, 2020 • edited Loading

pbaughman commented Feb 14, 2020

pbaughman commented Feb 15, 2020

pbaughman commented Feb 18, 2020

pbaughman commented Feb 28, 2020 • edited Loading

pbaughman commented Mar 3, 2020

sloretz commented Mar 5, 2020

pbaughman commented Mar 5, 2020

pbaughman commented Mar 5, 2020 • edited Loading

sloretz commented Mar 5, 2020 • edited Loading

sloretz commented Mar 5, 2020 • edited Loading

pbaughman commented Mar 6, 2020

jacobperron commented Mar 6, 2020

sloretz commented Mar 6, 2020

jacobperron commented Mar 6, 2020

jacobperron commented Mar 6, 2020

jacobperron left a comment

Choose a reason for hiding this comment

pbaughman commented Mar 6, 2020 • edited Loading

jacobperron commented Mar 6, 2020

sloretz commented Mar 6, 2020

pbaughman commented Oct 23, 2019 •

edited

Loading

pbaughman commented Feb 6, 2020 •

edited

Loading

sloretz commented Feb 6, 2020 •

edited

Loading

sloretz commented Feb 6, 2020 •

edited

Loading

pbaughman commented Feb 28, 2020 •

edited

Loading

pbaughman commented Mar 5, 2020 •

edited

Loading

sloretz commented Mar 5, 2020 •

edited

Loading

sloretz commented Mar 5, 2020 •

edited

Loading

pbaughman commented Mar 6, 2020 •

edited

Loading