Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: export config BE handler for transformer, and unstarted http test server #374

Merged
merged 4 commits into from
Mar 15, 2024

Conversation

mihir20
Copy link
Contributor

@mihir20 mihir20 commented Mar 13, 2024

Blocking rudderlabs/rudder-server#4473

Description

  • Export http request handler for BE Config, so that if someone wants to implement its own http client for BE Config for transformer need not to implement their own handler again.
  • Export NewUnstartedHttpServer to initialise a server that will be started(start serving request) at a later point in time

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-884/move-backend-config-unavailability-test-to-rudder-server-integration

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Mar 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.25%. Comparing base (0c2c23b) to head (f3749c6).

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #374       +/-   ##
===========================================
- Coverage   79.39%   67.25%   -12.15%     
===========================================
  Files          91       12       -79     
  Lines        6819      913     -5906     
===========================================
- Hits         5414      614     -4800     
+ Misses       1130      256      -874     
+ Partials      275       43      -232     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mihir20 mihir20 changed the title Mihir/pipe 884 chore: export config BE handler for transformer, and unstarted http test server Mar 13, 2024
@mihir20 mihir20 marked this pull request as ready for review March 13, 2024 17:21
testhelper/docker/resource/transformer/transformer.go Outdated Show resolved Hide resolved
testhelper/httptest/httptest_test.go Outdated Show resolved Hide resolved
testhelper/httptest/httptest_test.go Outdated Show resolved Hide resolved
@mihir20 mihir20 enabled auto-merge (squash) March 15, 2024 08:36
@mihir20 mihir20 merged commit 018b6f7 into main Mar 15, 2024
12 checks passed
@mihir20 mihir20 deleted the mihir/pipe-884 branch March 15, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants