avm1: Bail out of swapDepths on dead clips #2228
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's possible that swapDepths could be called on a removed clip, i.e. a
gotoAndStop
followed by aswapDepths
on a clip that is not on the new frame. This would futz up the display lists in AVM1 because currently we do not clear the parent assigned for dead clips (so thatunload
can work), and eventually this causes a panic. Instead, let's bail out of swapDepths if the clip has been removed. This fixes #2163 and others.This is a somewhat temporary fix until we clean up the related issues with removed AVM1 clips (#993, #1140, #1535). References to these removed clips need to become "invalid", which would more properly solve these issues (trying to call the
swapDepths
method or otherwise resolve these clips would silently fail).