Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 4 pull requests #1368

Closed
wants to merge 11 commits into from
Closed

Conversation

gnzlbg
Copy link
Contributor

@gnzlbg gnzlbg commented May 25, 2019

Successful merges:

Failed merges:

r? @ghost

malbarbo and others added 11 commits February 20, 2019 16:11
Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
Move to RUST_NIGHTLY_LINUX_TARGETS per gznlbg's suggestion.
 Move to LINUX_NO_CORE_TARGETS per gznlbg's suggestion.
Set the type for S_ISUID, S_ISGID and S_ISVTX correctly
Fix android SA_* constants

Trying to crosscompile wait-timeout to armv7-linux-androideabi I found that SA_* had different types in libc, but they have to be the same because they are used in bitwise operations.
Add powerpc64-unknown-freebsd target

Per rust-lang/stdarch#765 add powerpc64-unknown-freebsd to prevent further breakages.
Deprecate mach APIs: users should use the `mach` crate instead.

See rust-lang#981, the mach APIs have breaking changes from MacOSX SDK release to release, and that's pretty much what the users are seeing here. We are currently not exposing that many `mach` APIs in `libc`, so this PR deprecates them, forwarding users to use the `mach` crate instead, which provides the mach user-space APIs, is tested against multiple SDK versions, handles removed/deprecated/breaking API changes/etc. Doing all of that in `libc` feels overkill.

Closes rust-lang#981 .
@gnzlbg
Copy link
Contributor Author

gnzlbg commented May 25, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented May 25, 2019

📌 Commit a1ac2fc has been approved by gnzlbg

@gnzlbg
Copy link
Contributor Author

gnzlbg commented May 25, 2019

@bors: p=100

@bors
Copy link
Contributor

bors commented May 25, 2019

⌛ Testing commit a1ac2fc with merge 8adea96...

bors added a commit that referenced this pull request May 25, 2019
Rollup of 4 pull requests

Successful merges:

 - #503 (Set the type for S_ISUID, S_ISGID and S_ISVTX correctly)
 - #511 (Fix android SA_* constants)
 - #1358 (Add powerpc64-unknown-freebsd target)
 - #1364 (Deprecate mach APIs: users should use the `mach` crate instead.)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 25, 2019

💔 Test failed - checks-travis

@gnzlbg gnzlbg closed this May 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants