Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the type for S_ISUID, S_ISGID and S_ISVTX correctly #503

Merged
merged 1 commit into from
May 25, 2019
Merged

Set the type for S_ISUID, S_ISGID and S_ISVTX correctly #503

merged 1 commit into from
May 25, 2019

Conversation

TethysSvensson
Copy link
Contributor

No description provided.

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! Unfortunately this runs a relatively high risk of being a breaking change, so we may not be able to accept this until the next major version :(

@TethysSvensson
Copy link
Contributor Author

That's fair.

For the record, this is related to a nix cleanup I am working. I would be surprised if anybody except nix depends on those constants, but I guess it is better to be safe than sorry.

How far are you from the next major version?

@alexcrichton
Copy link
Member

We don't currently have a timeline for the next major release, unfortunately, but it's likely to happen at some point at least.

Susurrus pushed a commit to Susurrus/libc that referenced this pull request Mar 26, 2017
Fix the style for bitflags!

Prefer `libc_bitflags!` over `bitflags!`. Prefer `libc::CONSTANTS` over
writing the constant manually.

This makes rust-lang#501 unnecessary, since upstream now contains the `O_TMPFILE` constant.
@gnzlbg
Copy link
Contributor

gnzlbg commented Feb 20, 2019

@TethysSvensson could you rebase this? We can give this a try and see if it breaks anybody.

@TethysSvensson
Copy link
Contributor Author

@gnzlbg Done!

@gnzlbg
Copy link
Contributor

gnzlbg commented May 25, 2019

@bors: r+

@bors
Copy link
Contributor

bors commented May 25, 2019

📌 Commit 457b0f9 has been approved by gnzlbg

gnzlbg added a commit to gnzlbg/libc that referenced this pull request May 25, 2019
Set the type for S_ISUID, S_ISGID and S_ISVTX correctly
bors added a commit that referenced this pull request May 25, 2019
Rollup of 4 pull requests

Successful merges:

 - #503 (Set the type for S_ISUID, S_ISGID and S_ISVTX correctly)
 - #511 (Fix android SA_* constants)
 - #1358 (Add powerpc64-unknown-freebsd target)
 - #1364 (Deprecate mach APIs: users should use the `mach` crate instead.)

Failed merges:

r? @ghost
bors added a commit that referenced this pull request May 25, 2019
Set the type for S_ISUID, S_ISGID and S_ISVTX correctly
@bors
Copy link
Contributor

bors commented May 25, 2019

⌛ Testing commit 457b0f9 with merge ae24e22...

@bors
Copy link
Contributor

bors commented May 25, 2019

☀️ Test successful - checks-cirrus, checks-travis, status-appveyor
Approved by: gnzlbg
Pushing ae24e22 to master...

@bors bors merged commit 457b0f9 into rust-lang:master May 25, 2019
djkoloski pushed a commit to djkoloski/libc that referenced this pull request Apr 9, 2024
Fuchsia's definitions of these constants were split from the unix impls
before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly
typed as c_int instead of mode_t. This applies the same fix to Fuchsia's
constant definitions to bring them in line with the rest of libc.
JohnTitor pushed a commit to djkoloski/libc that referenced this pull request Apr 16, 2024
Fuchsia's definitions of these constants were split from the unix impls
before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly
typed as c_int instead of mode_t. This applies the same fix to Fuchsia's
constant definitions to bring them in line with the rest of libc.
djkoloski pushed a commit to djkoloski/libc that referenced this pull request Jun 10, 2024
Fuchsia's definitions of these constants were split from the unix impls
before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly
typed as c_int instead of mode_t. This applies the same fix to Fuchsia's
constant definitions to bring them in line with the rest of libc.
JohnTitor pushed a commit to djkoloski/libc that referenced this pull request Jun 16, 2024
Fuchsia's definitions of these constants were split from the unix impls
before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly
typed as c_int instead of mode_t. This applies the same fix to Fuchsia's
constant definitions to bring them in line with the rest of libc.
nyurik pushed a commit to nyurik/libc that referenced this pull request Jul 26, 2024
Fuchsia's definitions of these constants were split from the unix impls
before rust-lang#503, and so S_ISUID, S_ISGID, and S_ISVTX are all incorrectly
typed as c_int instead of mode_t. This applies the same fix to Fuchsia's
constant definitions to bring them in line with the rest of libc.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants