Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make description of Borrow trait uses match the example. #25452

Merged
merged 1 commit into from
May 19, 2015

Conversation

jimblandy
Copy link
Contributor

Minor tweak: the text explaining the Borrow trait talks about slices, but the example immediately following just uses a simple reference; there are no slices involved.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see CONTRIBUTING.md for more information.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 18, 2015

📌 Commit 0b04b17 has been approved by steveklabnik

@steveklabnik
Copy link
Member

Thank you!

@bors
Copy link
Contributor

bors commented May 18, 2015

⌛ Testing commit 0b04b17 with merge 3c56b74...

@bors
Copy link
Contributor

bors commented May 18, 2015

💔 Test failed - auto-linux-64-x-android-t

@steveklabnik
Copy link
Member

@bors: retry

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 18, 2015
Minor tweak: the text explaining the Borrow trait talks about slices, but the example immediately following just uses a simple reference; there are no slices involved.

r? @steveklabnik
Manishearth added a commit to Manishearth/rust that referenced this pull request May 19, 2015
Minor tweak: the text explaining the Borrow trait talks about slices, but the example immediately following just uses a simple reference; there are no slices involved.

r? @steveklabnik
bors added a commit that referenced this pull request May 19, 2015
@bors bors merged commit 0b04b17 into rust-lang:master May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants