-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
trpl/traits: Make error message consistent with source code snippet #25512
Conversation
The source code uses `"whatever".as_bytes()`, not `b"whatever"`.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
In this case I think it's actually somewhat more idiomatic to use the |
As a Rust beginner who started two days ago, I'll take your word for If |
Ah yeah I think it'd be fine to add a few words saying that |
The byte string literal syntax `b"whatever"` is more idiomatic than `"whatever".as_bytes()`.
@alexcrichton How about now? |
Thank you! |
…excrichton The source code snippet uses `"whatever".as_bytes()` but the compilation error message uses `b"whatever"`. Both should be consistent with each other. r? @steveklabnik
…excrichton The source code snippet uses `"whatever".as_bytes()` but the compilation error message uses `b"whatever"`. Both should be consistent with each other. r? @steveklabnik
The source code snippet uses
"whatever".as_bytes()
but the compilation error message usesb"whatever"
. Both should be consistent with each other.r? @steveklabnik