Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TRPL: Add rust Marker to Some Code Block #25580

Merged
merged 2 commits into from
May 19, 2015

Conversation

killercup
Copy link
Member

This adds strictly more information to the source files and reduces the need for customized tooling to render the book. (While this should not change the output of rustbook, it is very useful when rendering the sources with external tools like Pandoc.)

This only adds the language marker to "first level" code blocks (and not to code blocks in comments inside of code examples).

r? @steveklabnik

This adds strictly more information to the source files and reduces the
need for customized tooling to render the book.

(While this should not change the output of _rustbook_, it is very
useful when rendering the sources with external tools like Pandoc.)
@steveklabnik
Copy link
Member

Thanks so much! ❤️

I've been meaning to do this, as it's convention. Also, for further work, i think there's some {rust}s lying around too... heh

@steveklabnik
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented May 18, 2015

📌 Commit 6f69cd6 has been approved by steveklabnik

@steveklabnik
Copy link
Member

@bors: rollup

@killercup
Copy link
Member Author

Oh, let me look for {rust} real quick and I'll fix those as well.

BTW, whats the convention? rust,ignore or {rust,ignore}?

@steveklabnik
Copy link
Member

It is now to never use the {}s, basically.

@killercup
Copy link
Member Author

Alright, I'll fix those as well.

`{rust,ignore}` -> `rust,ignore
@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 18, 2015

📌 Commit f3adea5 has been approved by steveklabnik

steveklabnik added a commit to steveklabnik/rust that referenced this pull request May 18, 2015
…=steveklabnik

This adds strictly more information to the source files and reduces the need for customized tooling to render the book. (While this should not change the output of _rustbook_, it is very useful when rendering the sources with external tools like Pandoc.)

This only adds the language marker to "first level" code blocks (and not to code blocks in comments inside of code examples).

r? @steveklabnik
Manishearth added a commit to Manishearth/rust that referenced this pull request May 19, 2015
…=steveklabnik

This adds strictly more information to the source files and reduces the need for customized tooling to render the book. (While this should not change the output of _rustbook_, it is very useful when rendering the sources with external tools like Pandoc.)

This only adds the language marker to "first level" code blocks (and not to code blocks in comments inside of code examples).

r? @steveklabnik
bors added a commit that referenced this pull request May 19, 2015
@bors bors merged commit f3adea5 into rust-lang:master May 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants