Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove function invokation parens from documentation links. #40456

Merged
merged 1 commit into from
Mar 17, 2017
Merged

Remove function invokation parens from documentation links. #40456

merged 1 commit into from
Mar 17, 2017

Conversation

frewsxcv
Copy link
Member

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

This PR was generated via:

find . -name "*.md" | xargs gsed -i 's/\[\([^ ]*\)()`\]/[\1`]/g'
find . -name "*.rs" | xargs gsed -i 's/\[\([^ ]*\)()`\]/[\1`]/g'

@frewsxcv
Copy link
Member Author

cc @rust-lang/docs

@GuillaumeGomez
Copy link
Member

I'm still sad about this. :'(

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 13, 2017

📌 Commit eee5ec1 has been approved by GuillaumeGomez

ollie27
ollie27 reviewed Mar 13, 2017
View reviewed changes
src/libstd/thread/mod.rs Outdated
//! [`thread::park()`][`park()`] function and [`thread::Thread::unpark()`][`unpark()`]
//! method. [`park()`] blocks the current thread, which can then be resumed from
//! another thread by calling the [`unpark()`] method on the blocked thread's handle.
//! [`thread::park()`][`park`] function and [`thread::Thread::unpark()`][`unpark`]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a couple

src/libstd/thread/mod.rs Outdated
//!
//! Conceptually, each [`Thread`] handle has an associated token, which is
//! initially not present:
//!
//! * The [`thread::park()`][`park()`] function blocks the current thread unless or until
//! * The [`thread::park()`][`park`] function blocks the current thread unless or until
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@steveklabnik
Copy link
Member

@bors: r-

thanks @ollie27

me too @GuillaumeGomez

@frewsxcv
Remove function invokation parens from documentation links.
e7b0f2b 
This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv force-pushed the frewsxcv-docs-function-parens branch from eee5ec1 to e7b0f2b Compare March 14, 2017 01:43
@GuillaumeGomez
Copy link
Member

Seems fixed now.

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit e7b0f2b has been approved by GuillaumeGomez

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 14, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
2853a9b 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 15, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
85f10d8 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 15, 2017
Closed
bors added a commit that referenced this pull request Mar 15, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
b5ccda0 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
bors added a commit that referenced this pull request Mar 16, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
d62dea5 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
f3bad46 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
35c8956 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
cbbc012 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40456 - frewsxcv:frewsxcv-docs-function-par…
6971717 
…ens, r=GuillaumeGomez

Remove function invokation parens from documentation links.

This was never established as a convention we should follow in the 'More
API Documentation Conventions' RFC:

https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Merged
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40598 - frewsxcv:rollup, r=frewsxcv
a559452 
Rollup of 23 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40458, #40463, #40466, #40467, #40495, #40496, #40497, #40499, #40500, #40503, #40505, #40512, #40514, #40517, #40520, #40536, #40545, #40586
- Failed merges:
@bors bors merged commit e7b0f2b into rust-lang:master Mar 17, 2017
@frewsxcv frewsxcv deleted the frewsxcv-docs-function-parens branch March 20, 2017 01:00
@frewsxcv frewsxcv mentioned this pull request May 7, 2017
Merged
@frewsxcv frewsxcv mentioned this pull request May 14, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ollie27 ollie27 ollie27 left review comments

Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@frewsxcv @rust-highfive @GuillaumeGomez @bors @steveklabnik @ollie27 @aturon