Rollup of 18 pull requests #40544
Closed
Rollup of 18 pull requests #40544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of last year with version 'Sierra', the Mac operating system is now called 'macOS'.
This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
Primarily opened to address the concerns brought up in rust-lang#40498. * run rustfmt on code blocks * use `DefaultHasher` instead of deprecated `SipHasher` * rename `hash` to `calculate_hash` to prevent confusion with the `hash` method
@jongiddy noticed bad performance due to the lack of inlining on `then` and `then_with`. I confirmed that inlining really is the culprit by creating a custom `then` function and repeating his benchmark on my machine with and without the `#[inline]` attribute. The numbers were exactly the same on my machine without the attribute. With `#[inline]` I got the same performance as I did with manually inlined implementation.
Whenever we parse a chain of binary operations, as long as the first
operation is `<` and the subsequent operations are either `>` or `<`,
present the following diagnostic help:
use `::<...>` instead of `<...>` if you meant to specify type arguments
This will lead to spurious recommendations on situations like
`2 < 3 < 4` but should be clear from context that the help doesn't apply
in that case.
Add test for issue rust-lang#29595 Closes rust-lang#29595 Couldn't get this to run locally, all the compile-fail tests are ignored... let's see what Travis says.
…GuillaumeGomez Add basic documentation/examples for six unstable features.
…ens, r=GuillaumeGomez Remove function invokation parens from documentation links. This was never established as a convention we should follow in the 'More API Documentation Conventions' RFC: https://github.com/rust-lang/rfcs/blob/master/text/1574-more-api-documentation-conventions.md
…bnik Update usages of 'OSX' (and other old names) to 'macOS'. As of last year with version 'Sierra', the Mac operating system is now called 'macOS'.
some style fixes
|
💔 Test failed - status-travis |
|
… On Wed, Mar 15, 2017 at 8:50 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/211341771>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40544 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95GEz2AOXJLZl5CRu8x2rk-e9HhYiks5rl-yTgaJpZM4Md6j4>
.
|
bors
added a commit
that referenced
this pull request
Mar 15, 2017
|
💔 Test failed - status-travis |
|
@bors retry mac things didn't even run |
|
⌛ Testing commit a2d2a97 with merge 798ee19... |
|
💔 Test failed - status-travis |
|
… On Wed, Mar 15, 2017 at 10:44 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/211605302>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40544 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95NTWEW7thVr5VjRHOeRfmxfI6m_rks5rmLAJgaJpZM4Md6j4>
.
|
|
⌛ Testing commit a2d2a97 with merge 32468fc... |
|
💔 Test failed - status-travis |
|
… On Thu, Mar 16, 2017 at 4:44 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/211635717>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40544 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95JPTnxto7aQLAW__3O9E-uA-dw3hks5rmQSHgaJpZM4Md6j4>
.
|
|
⌛ Testing commit a2d2a97 with merge 8d9eb05... |
|
💔 Test failed - status-travis |
bors
added a commit
that referenced
this pull request
Mar 16, 2017
|
💔 Test failed - status-travis |
|
⌛ Testing commit a2d2a97 with merge 585ac0a... |
|
💔 Test failed - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
srcforptr::write{,_unaligned}#40387, Add test for issue #29595 #40433, Add basic documentation/examples for six unstable features. #40452, Remove function invokation parens from documentation links. #40456, Update usages of 'OSX' (and other old names) to 'macOS'. #40457, some style fixes #40463, Remove doc about highlighting code in other languages #40301 #40466, Updating README.md to point to the correct doc location #40467, fix format grammar #40495, Using X headings #39850 #40496, Fix sidebar not extending to the bottom of the page #40497, Point out correct turbofish usage onFoo<Bar<Baz>>#40500, std: remove a workaround for privacy limitations #40503, A few improvements to thecore::hashtop-level docs. #40505, .gitmodules: use official URLs w/o redirect #40512, Inline functions Ordering::{then, then_with} #40514, Remove incorrect feature from the 1.16 relnotes #40517, Link core::slice to std::slice #40520