Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove doc about highlighting code in other languages #40301 #40466

Merged
merged 2 commits into from
Mar 17, 2017
Merged

Remove doc about highlighting code in other languages #40301 #40466

merged 2 commits into from
Mar 17, 2017

Conversation

projektir
Copy link
Contributor

@projektir projektir commented Mar 13, 2017 •
edited
Loading

This doesn't appear to be true any longer, so removing it to avoid confusion. See #40301

Thoughts:

  • may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
  • does text still work?

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@steveklabnik
Copy link
Member

does text still work?

Yeah, text is a thing

@steveklabnik
Copy link
Member

may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;

Sounds good 👍

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Mar 14, 2017

📌 Commit eb203d5 has been approved by steveklabnik

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 14, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
1328cd4 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 14, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
7cf0a09 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 14, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 15, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
e62a282 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 15, 2017
Closed
bors added a commit that referenced this pull request Mar 15, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
b5ccda0 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
bors added a commit that referenced this pull request Mar 16, 2017
@bors
Auto merge of #40544 - frewsxcv:rollup, r=frewsxcv
d62dea5 
Rollup of 18 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40463, #40466, #40467, #40495, #40496, #40497, #40500, #40503, #40505, #40512, #40514, #40517, #40520
- Failed merges:
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
8eae8f7 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
58a2371 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
24fae27 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Mar 17, 2017
@frewsxcv
Rollup merge of rust-lang#40466 - projektir:outdated_docs_highlightin…
127c3ad 
…g, r=steveklabnik

Remove doc about highlighting code in other languages rust-lang#40301

This doesn't appear to be true any longer, so removing it to avoid confusion. See rust-lang#40301

Thoughts:
- may be a good idea to remove "Let's discuss the details of these code blocks.", as there's not much being discussed at this point;
- does `text` still work?

r? @steveklabnik
@frewsxcv frewsxcv mentioned this pull request Mar 17, 2017
Merged
bors added a commit that referenced this pull request Mar 17, 2017
@bors
Auto merge of #40598 - frewsxcv:rollup, r=frewsxcv
a559452 
Rollup of 23 pull requests

- Successful merges: #40387, #40433, #40452, #40456, #40457, #40458, #40463, #40466, #40467, #40495, #40496, #40497, #40499, #40500, #40503, #40505, #40512, #40514, #40517, #40520, #40536, #40545, #40586
- Failed merges:
@bors bors merged commit eb203d5 into rust-lang:master Mar 17, 2017
@projektir projektir deleted the outdated_docs_highlighting branch March 18, 2017 23:16
@steveklabnik steveklabnik mentioned this pull request Mar 22, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@projektir @rust-highfive @steveklabnik @bors