Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libcore: Implement cloned() for Option<&mut T> #43705

Merged
merged 3 commits into from
Aug 30, 2017
Merged

libcore: Implement cloned() for Option<&mut T> #43705

merged 3 commits into from
Aug 30, 2017

Conversation

panicbit
Copy link
Contributor

@panicbit panicbit commented Aug 6, 2017

No description provided.

@panicbit panicbit force-pushed the option_ref_mut_cloned branch from 8acd6e1 to 51b29d6 Compare August 7, 2017 00:24
oli-obk
oli-obk reviewed Aug 7, 2017
View reviewed changes
src/libcore/option.rs Outdated
/// # Examples
///
/// ```
/// let mut x = 12;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add a #![feature(option_ref_mut_cloned)] to the doc example.

@arielb1 arielb1 added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2017
@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

r? @oli-obk I think (does this need an RFC?)

@arielb1
Copy link
Contributor

arielb1 commented Aug 8, 2017

I guess this does need an RFC + tracking issue + stabilization track.

@oli-obk
Copy link
Contributor

oli-obk commented Aug 8, 2017

r? @oli-obk I think

I have no bors-powers.

I guess this does need an RFC + tracking issue + stabilization track.

I don't think it needs an RFC, since we already have the implementation for Option<&T>, this is just a natural extension of that impl.

Definitely needs a tracking issue + must be unstable.

@panicbit panicbit mentioned this pull request Aug 8, 2017
Closed
@carols10cents
Copy link
Member

r? @aturon

@aturon aturon added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Aug 22, 2017
@aturon
Copy link
Member

aturon commented Aug 22, 2017

Hey, sorry for the late review!

cc @rust-lang/libs, how do y'all feel about adding this API?

@sfackler
Copy link
Member

SGTM. There aren't any other methods on Option<&T> we'd also want to copy over, right?

@dtolnay
Copy link
Member

dtolnay commented Aug 23, 2017

LGTM as well. There are no other methods.

@alexcrichton
Copy link
Member

👍

@carols10cents
Copy link
Member

@aturon ping, it sounds like libs is cool with this?

@aturon
Copy link
Member

aturon commented Aug 29, 2017

@bors: r+

Thanks for the PR, and sorry for the delay!

@bors
Copy link
Contributor

bors commented Aug 29, 2017

📌 Commit 9618299 has been approved by aturon

arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#43705 - panicbit:option_ref_mut_cloned, r=a…
f2d7045 
…turon

libcore: Implement cloned() for Option<&mut T>

None
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Closed
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Closed
@bors
Copy link
Contributor

bors commented Aug 29, 2017

⌛ Testing commit 9618299 with merge 3f0af79cd4c5abc9b3eb96e2a5ac4fdb2a874695...

arielb1 pushed a commit to arielb1/rust that referenced this pull request Aug 29, 2017
Rollup merge of rust-lang#43705 - panicbit:option_ref_mut_cloned, r=a…
11e75fd 
…turon

libcore: Implement cloned() for Option<&mut T>

None
@arielb1 arielb1 mentioned this pull request Aug 29, 2017
Merged
@arielb1
Copy link
Contributor

arielb1 commented Aug 29, 2017

@bors retry

prioritizing rollup which includes this

bors added a commit that referenced this pull request Aug 29, 2017
@bors
Auto merge of #44169 - arielb1:rollup, r=arielb1
c11f689 
Rollup of 12 pull requests

- Successful merges: #43705, #43778, #43918, #44076, #44117, #44121, #44126, #44134, #44135, #44141, #44144, #44158
- Failed merges:
@bors bors merged commit 9618299 into rust-lang:master Aug 30, 2017
@panicbit panicbit deleted the option_ref_mut_cloned branch August 30, 2017 11:25
@panicbit panicbit restored the option_ref_mut_cloned branch August 30, 2017 23:44
@CAD97 CAD97 mentioned this pull request Aug 31, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oli-obk oli-obk oli-obk left review comments

Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@panicbit @arielb1 @oli-obk @carols10cents @aturon @sfackler @dtolnay @alexcrichton @bors