-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustbuild: Fix dependencies of build-manifest #44144
Conversation
No need to depend on librustc! All we need is libstd Closes rust-lang#44140
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Good point. I think the original reason this was librustc is because it depends on proc macros, but since we currently build in stage0 that's fine I believe. Worst case is it doesn't work (and I assume we test that somewhere and at least manually). @bors r+ |
📌 Commit ecd127d has been approved by |
@bors rollup |
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
We're gonna backport this to make deployments easier on beta/stable |
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
No need to depend on librustc! All we need is libstd
Closes #44140