-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 12 pull requests #44169
Merged
Merged
Rollup of 12 pull requests #44169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation here is to allow rustfmt to recover from parse errors after failing to parse macros.
distcheck complains that this file references projects not cotnained in the tarball
Make the ./x.py script fail when run with an invalid command, like: ./x.py nonsense This helps in case of chaining multiple runs, eg.: ./x.py biuld && ./x.py test
The crate itself is internally referenced by serde_derive.
in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios
No need to depend on librustc! All we need is libstd Closes rust-lang#44140
…turon libcore: Implement cloned() for Option<&mut T> None
…, r=arielb1 Add reset_err_count() to errors::Handler The motivation here is to allow rustfmt to recover from parse errors after failing to parse macros (cc rust-lang/rustfmt#1742). r? @nrc
…avus Don't highlight # which does not start an attribute in rustdoc Currently when we highlight some macros for rustdoc (e.g. `quote!` from https://github.com/dtolnay/quote), we get really bad syntax highlighting, because we assume that every token between a `#` character and the next `]` in the source must be an attribute. This patch improves that highlighting behavior to instead only highlight after finding the `[` token after the `#` token. (NOTE: I've only run this patch against https://github.com/nrc/rustdoc-highlight so if it doesn't build on travis that's why - I don't have a recent rustc build on this laptop) I'm guessing r? @steveklabnik
include Cargo.{toml,lock} in rust-src tarball The lock file is interesting because e.g. xargo could use it to build libstd against the same dependencies that were used for the main build. More generally speaking, just documenting in this form which exact dependencies should be used IMHO makes lots of sense. I added the Cargo.toml mostly because having the lock without the toml feels odd. Of course, the toml contains references to paths that don't actually exist in the rust-src tarball. Not sure if that is considered a problem.
…xamples, r=QuietMisdreavus Rewrite `std::net::ToSocketAddrs` doc examples. in particular: * show how to create an iterator that yields multiple socket addresses * show more failing scenarios done this as preliminary work while investigating rust-lang#22569 note: i haven't run doc tests on my machine for this, so would be good to confirm CI passes before approving
… r=Mark-Simulacrum bootstrap: remove unneeded extern crate The crate itself is internally referenced by serde_derive.
…matsakis compiletest: Change Config comments to doc comments I plan to make the same change in compiletest-rs, to have some documentation in [the docs](https://docs.rs/compiletest_rs/0.2.9/compiletest_rs/common/struct.Config.html).
…akis Fail ./x.py on invalid command Make the ./x.py script fail when run with an invalid command, like: ``` ./x.py nonsense ``` This helps in case of chaining multiple runs, eg.: ``` ./x.py biuld && ./x.py test ```
…etMisdreavus Fix invalid linker position Fixes rust-lang#44120. Result isn't "optimal" though because there are spaces at the end of some lines.
Rename the rls component to rls-preview on beta/stable Background is that we will have automatic renaming with the next rustup release. We'll then rename rls to rls-preview. In the meantime, this ensures beta/stable users will always have rls-preview. r? @alexcrichton
…r=Mark-Simulacrum rustbuild: Fix dependencies of build-manifest No need to depend on librustc! All we need is libstd Closes rust-lang#44140
Use a byte literal ASCII 0 instead of its decimal value @SimonSapin noticed this in dtolnay/itoa#8.
Some changes occurred in HTML/CSS. |
(rust_highfive has picked a reviewer for you, use r? to override) |
@bors r+ p=10 |
📌 Commit be0ac01 has been approved by |
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::net::ToSocketAddrs
doc examples. #44117, bootstrap: remove unneeded extern crate #44121, compiletest: Change Config comments to doc comments #44126, Fail ./x.py on invalid command #44134, Fix invalid linker position #44135, Rename the rls component to rls-preview on beta/stable #44141, rustbuild: Fix dependencies of build-manifest #44144, Use a byte literal ASCII 0 instead of its decimal value #44158