Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update unimplemented! docs #44206

Merged
merged 3 commits into from
Sep 7, 2017
Merged

update unimplemented! docs #44206

merged 3 commits into from
Sep 7, 2017

Conversation

MarkMcCaskey
Copy link
Contributor

For #42628 (updating docs from changes from #42155).

Initial changes made to make unimplemented! doc comments look more like unreachable! and remove statement about the panic message.

r? @steveklabnik

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@bors
Copy link
Contributor

bors commented Aug 31, 2017

☔ The latest upstream changes (presumably #44186) made this pull request unmergeable. Please resolve the merge conflicts.

@aidanhs
Copy link
Member

aidanhs commented Aug 31, 2017

Thanks for the PR @MarkMcCaskey! We'll check in now and again to make sure @steveklabnik or another reviewer gets to this soon.

@aidanhs
Copy link
Member

aidanhs commented Aug 31, 2017

(in the meantime, I note there are merge conflicts - it'd be great if you could resolve those)

@shepmaster shepmaster added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 1, 2017
@MarkMcCaskey
Copy link
Contributor Author

Okay! Sorry about the long delay. Should be fine now.

@steveklabnik
Copy link
Member

@bors: r+ rollup

thank you!

@bors
Copy link
Contributor

bors commented Sep 5, 2017

📌 Commit 570ae39 has been approved by steveklabnik

@arielb1 arielb1 added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Sep 5, 2017
@kennytm kennytm mentioned this pull request Sep 6, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44206 - MarkMcCaskey:master, r=steveklabnik
0420654 
update unimplemented! docs

For rust-lang#42628 (updating docs from changes from rust-lang#42155).

Initial changes made to make `unimplemented!` doc comments look more like `unreachable!` and remove statement about the panic message.

r? @steveklabnik
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44206 - MarkMcCaskey:master, r=steveklabnik
b8812a2 
update unimplemented! docs

For rust-lang#42628 (updating docs from changes from rust-lang#42155).

Initial changes made to make `unimplemented!` doc comments look more like `unreachable!` and remove statement about the panic message.

r? @steveklabnik
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit 570ae39 into rust-lang:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MarkMcCaskey @rust-highfive @bors @aidanhs @steveklabnik @shepmaster @arielb1