Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std/time: Give an example to get UNIX_EPOCH in seconds #44315

Merged
merged 1 commit into from
Sep 7, 2017
Merged

std/time: Give an example to get UNIX_EPOCH in seconds #44315

merged 1 commit into from
Sep 7, 2017

Conversation

kallisti5
Copy link
Contributor

No description provided.

@kallisti5
Copy link
Contributor Author

r? @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @sfackler

(rust_highfive has picked a reviewer for you, use r? to override)

@kallisti5
Copy link
Contributor Author

rebased from PR #44301

GuillaumeGomez
GuillaumeGomez reviewed Sep 4, 2017
View reviewed changes
src/libstd/time/mod.rs Outdated
/// match SystemTime::now().duration_since(UNIX_EPOCH) {
/// Ok(n) => println!("1970-01-01 00:00:00 UTC was {} seconds ago!", n.as_secs()),
/// Err(_) => panic!("SystemTime before UNIX EPOCH!"),
/// };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless semicolon.

@GuillaumeGomez
Copy link
Member

And just push -f on your branch, no need to recreate a PR. ;)

@kallisti5 kallisti5 force-pushed the epoch-doc-example-squashed branch from 935d29e to 1c5bf24 Compare September 5, 2017 00:22
@kallisti5
Copy link
Contributor Author

Oh, I didn't realize you could force a push updating a remote branch without breaking everything at github.. neat! Done.

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Sep 5, 2017

📌 Commit 1c5bf24 has been approved by GuillaumeGomez

@arielb1 arielb1 added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 5, 2017
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 6, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44315 - kallisti5:epoch-doc-example-squashe…
dc5c94d 
…d, r=GuillaumeGomez

std/time: Give an example to get UNIX_EPOCH in seconds
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 6, 2017
Closed
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44315 - kallisti5:epoch-doc-example-squashe…
fdb8d0b 
…d, r=GuillaumeGomez

std/time: Give an example to get UNIX_EPOCH in seconds
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors bors merged commit 1c5bf24 into rust-lang:master Sep 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez left review comments

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kallisti5 @rust-highfive @GuillaumeGomez @bors @sfackler @arielb1