Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor documentation improvements for StmtKind #44296

Merged
merged 2 commits into from
Sep 7, 2017
Merged

Minor documentation improvements for StmtKind #44296

merged 2 commits into from
Sep 7, 2017

Conversation

zmanian
Copy link
Contributor

@zmanian zmanian commented Sep 3, 2017

Documentation for Semi and Marco StmtKinds.

Wasn't obvious to me what these were when writing a lint recently.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

steveklabnik
steveklabnik suggested changes Sep 5, 2017
View reviewed changes
Copy link
Member

@steveklabnik steveklabnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after fixing the whitespace issue, r=me. Thank you!

src/libsyntax/ast.rs Outdated
Semi(P<Expr>),

/// Macro.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this has a trailing space, ✂️

@arielb1 arielb1 added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Sep 5, 2017
@petrochenkov
Copy link
Contributor

petrochenkov commented Sep 6, 2017 •
edited
Loading

@bors r=steveklabnik rollup
Thanks!

@bors
Copy link
Contributor

bors commented Sep 6, 2017

📌 Commit af3536d has been approved by steveklabnik

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 7, 2017
@Mark-Simulacrum
Rollup merge of rust-lang#44296 - zmanian:patch-1, r=steveklabnik
fee0b67 
Minor documentation improvements for StmtKind

Documentation for Semi and Marco StmtKinds.

Wasn't obvious to me what these were when writing a lint recently.
@Mark-Simulacrum Mark-Simulacrum mentioned this pull request Sep 7, 2017
Merged
bors added a commit that referenced this pull request Sep 7, 2017
@bors
Auto merge of #44380 - Mark-Simulacrum:rollup, r=Mark-Simulacrum
05e3c96 
Rollup of 23 pull requests

- Successful merges: #44097, #44206, #44218, #44276, #44277, #44296, #44303, #44313, #44315, #44317, #44319, #44321, #44325, #44326, #44327, #44328, #44330, #44351, #44353, #44354, #44361, #44362, #44377
- Failed merges:
@bors
Copy link
Contributor

bors commented Sep 7, 2017

☔ The latest upstream changes (presumably #44380) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors merged commit af3536d into rust-lang:master Sep 7, 2017
@zmanian zmanian deleted the patch-1 branch September 7, 2017 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveklabnik steveklabnik steveklabnik requested changes

Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@zmanian @rust-highfive @petrochenkov @bors @steveklabnik @pnkfelix @arielb1