Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include VS 2017 in error message. #52055

Merged
merged 2 commits into from
Jul 6, 2018
Merged

Include VS 2017 in error message. #52055

merged 2 commits into from
Jul 6, 2018

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Jul 4, 2018

Update error prompt message to indicate that VS 2017 is supported (for a while now).

@crlf0710
Include VS 2017 in error message.
1dae60e 
Update error prompt message to indicate that VS 2017 is supported (for a while now).
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 4, 2018
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 4, 2018

📌 Commit 1dae60e has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2018
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-3.9 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log. 

[00:04:37] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:37] tidy error: /checkout/src/librustc_codegen_llvm/back/link.rs:819: line longer than 100 chars
[00:04:39] some tidy checks failed
[00:04:39] 
[00:04:39] 
[00:04:39] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:39] 
[00:04:39] 
[00:04:39] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:39] Build completed unsuccessfully in 0:01:40
[00:04:39] Build completed unsuccessfully in 0:01:40
[00:04:39] make: *** [tidy] Error 1
[00:04:39] Makefile:79: recipe for target 'tidy' failed

The command "stamp sh -x -c "$RUN_SCRIPT"" exited with 2.
travis_time:start:17558dc8
$ date && (curl -fs --head https://google.com | grep ^Date: | sed 's/Date: //g' || true)
---
travis_time:end:134c0374:start=1530716236866009192,finish=1530716236873579748,duration=7570556
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:10876add
$ head -30 ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
head: cannot open ‘./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers’ for reading: No such file or directory
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0500833b
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@crlf0710
Shorten the line
30063ae 
Shorten the line to make tidy happy.
@kennytm
Copy link
Member

kennytm commented Jul 6, 2018

@bors r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 6, 2018

📌 Commit 30063ae has been approved by Mark-Simulacrum

kennytm added a commit to kennytm/rust that referenced this pull request Jul 6, 2018
@kennytm
Rollup merge of rust-lang#52055 - crlf0710:patch-3, r=Mark-Simulacrum
fb839bc 
Include VS 2017 in error message.

Update error prompt message to indicate that VS 2017 is supported (for a while now).
@kennytm kennytm mentioned this pull request Jul 6, 2018
Merged
bors added a commit that referenced this pull request Jul 6, 2018
@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm
bff0090 
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52052 (Make verbose --version show if parallel queries are supported.)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #51953 (enable Atomic*.{load,store} for ARMv6-M / MSP430)

Failed merges:
kennytm added a commit to kennytm/rust that referenced this pull request Jul 6, 2018
@kennytm
Rollup merge of rust-lang#52055 - crlf0710:patch-3, r=Mark-Simulacrum
3c21349 
Include VS 2017 in error message.

Update error prompt message to indicate that VS 2017 is supported (for a while now).
bors added a commit that referenced this pull request Jul 6, 2018
@bors
Auto merge of #52088 - kennytm:rollup, r=kennytm
4d9fa23 
Rollup of 14 pull requests

Successful merges:

 - #51619 (rust: add initial changes to support powerpc64le musl)
 - #51793 (Fix variant background color on hover in search results)
 - #52005 (Update LLVM to bring in a wasm codegen fix)
 - #52016 (Deduplicate error reports for statics)
 - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD))
 - #52030 (Any docs preposition change)
 - #52031 (Strenghten synchronization in `Arc::is_unique`)
 - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar)
 - #52055 (Include VS 2017 in error message.)
 - #52063 (Add a link to the rustc docs)
 - #52073 (Add a punch card to weird expressions test)
 - #52080 (Improve dependency deduplication diagnostics)
 - #52093 (rustc: Update tracking issue for wasm_import_module)
 - #52096 (Fix typo in cell.rs)

Failed merges:
@bors bors merged commit 30063ae into rust-lang:master Jul 6, 2018
@crlf0710 crlf0710 deleted the patch-3 branch July 6, 2018 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@crlf0710 @rust-highfive @Mark-Simulacrum @bors @kennytm @nikomatsakis