Rollup of 14 pull requests #52088
Merged
Rollup of 14 pull requests #52088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amend powerpc64le_unknown_linux_musl.rs to fix copyright date
This changes the docs referring to where a user should be wary of depending on "Any" trait impls from warning about relying on them "outside" of their code to warning about relying on them "inside" of their code.
Previously, `is_unique` would not synchronize at all with a `drop` that returned early because it was not the last reference, leading to a data race. Fixes rust-lang#51780
Update error prompt message to indicate that VS 2017 is supported (for a while now).
Shorten the line to make tidy happy.
rust: add initial changes to support powerpc64le musl Initial changes to support rustc building on ppc64le with musl. A PR was also submitted to libc component rust-lang/libc#1023 to add changes to libc musl definitions. A PR was submitted on Alpine alpinelinux/aports#4549 with equivalent temporary patches for building on Alpine for now. As a verification test a github project was put together to build ppc64le versions of rustc, rust-stdlib, and cargo on Alpine, https://github.com/mksully22/ppc64le_alpine_rust_1.26.2
… r=QuietMisdreavus Fix variant background color on hover in search results Fixes rust-lang#51792. <img width="1440" alt="screen shot 2018-06-26 at 00 37 24" src="https://user-images.githubusercontent.com/3050060/41879313-60ecf3be-78d9-11e8-9986-21af529ab758.png"> r? @QuietMisdreavus
|
@bors r+ p=13 |
|
📌 Commit 0a3756b5b0b1aff866972e171e9e6d367de2301c has been approved by |
bors
added
the
S-waiting-on-bors
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
⌛ Testing commit 0a3756b5b0b1aff866972e171e9e6d367de2301c with merge 67b3b2d62abb8f7360050be64d9ba81ebcc6c2fb... |
|
@bors r- retry Failed CI |
bors
added
S-waiting-on-author
…r=kennytm Update LLVM to bring in a wasm codegen fix Closes rust-lang#51986
…bank Deduplicate error reports for statics fixes rust-lang#51970
…gin, r=alexcrichton [cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD) This PR allows for not specifying an LTO-linker plugin but still let `rustc` invoke the linker with the correct plugin arguments. This is useful when using LLD which does not need the `-plugin` argument. Since LLD is the best linker for this scenario anyway, this change should improve ergonomics quite a bit. r? @alexcrichton
Any docs preposition change This changes the docs referring to where a user should be wary of depending on "Any" trait impls from warning about relying on them "outside" of their code to warning about relying on them "inside" of their code.
|
@bors retry A build script segfault, assuming spurious for now. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 5da9fdc with merge 01c430a5043cc55a2f2ac4e9c8d6f8384cefd0a1... |
|
@bors: r- Ah nah I think that's a bug in |
bors
added
S-waiting-on-author
Add a punch card to weird expressions test
…nnytm Improve dependency deduplication diagnostics r? @kennytm this is obviously hard to test 😆 cc rust-lang#52072
Include VS 2017 in error message. Update error prompt message to indicate that VS 2017 is supported (for a while now).
Add a link to the rustc docs
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
rustc: Update tracking issue for wasm_import_module It's now rust-lang#52090
Fix typo in cell.rs
|
📌 Commit e6ddbab has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Jul 6, 2018
Rollup of 14 pull requests Successful merges: - #51619 (rust: add initial changes to support powerpc64le musl) - #51793 (Fix variant background color on hover in search results) - #52005 (Update LLVM to bring in a wasm codegen fix) - #52016 (Deduplicate error reports for statics) - #52019 ([cross-lang-lto] Allow the linker to choose the LTO-plugin (which is useful when using LLD)) - #52030 (Any docs preposition change) - #52031 (Strenghten synchronization in `Arc::is_unique`) - #52033 ([Gardening] Update outdated comments: ByVal -> Scalar) - #52055 (Include VS 2017 in error message.) - #52063 (Add a link to the rustc docs) - #52073 (Add a punch card to weird expressions test) - #52080 (Improve dependency deduplication diagnostics) - #52093 (rustc: Update tracking issue for wasm_import_module) - #52096 (Fix typo in cell.rs) Failed merges:
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Arc::is_unique#52031 (Strenghten synchronization inArc::is_unique)Failed merges: