libtest terse format: show how far in we are #53428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @KodrAus (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Hmm, I like the idea of working the total count into the interface too. The API is still unstable and malleable so I'm comfortable with tweaking it. |
|
Hm actually that would likely be incorrect -- the actual number seems to only be determined after some filtering. It is not known yet when the formatter is constructed. So I think the code as it is right now is actually the best we can do currently. |
|
Ah I see. Well, in that case this looks good to me 👍 @bors r+ |
|
📌 Commit ffbb407 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Aug 26, 2018
libtest terse format: show how far in we are So for example `./x.py test src/libcore` looks like ``` running 881 tests .................................................................................................... 100/881 .................................................................................................... 200/881 .................................................................................................... 300/881 .............................................................i.i.................................... 400/881 .................................................................................................... 500/881 .................................................................................................... 600/881 .................................................................................................... 700/881 .................................................................................................... 800/881 ................................................................................. test result: ok. 879 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out ``` When I am waiting for 3500 ui tests to complete, I am often missing some sense of how far in these 3500 it is. Getting the total count in `write_run_start` is a bit hacky; I did that to not change the "public interface" of the formatters. I can also give them an extra argument in their constructor so that they know from the beginning how many tests there will be. Would you prefer that? (I think I would, but I wanted to get feedback first.)
bors
added a commit
that referenced
this pull request
Aug 26, 2018
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
bors
added a commit
that referenced
this pull request
Aug 26, 2018
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So for example
./x.py test src/libcorelooks likeWhen I am waiting for 3500 ui tests to complete, I am often missing some sense of how far in these 3500 it is.
Getting the total count in
write_run_startis a bit hacky; I did that to not change the "public interface" of the formatters. I can also give them an extra argument in their constructor so that they know from the beginning how many tests there will be. Would you prefer that? (I think I would, but I wanted to get feedback first.)