rustdoc: Fix gap on section anchor symbol when hovering. #53706
Conversation
Fixes rust-lang#49485 for section headings.
|
Some changes occurred in HTML/CSS. |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Do you have an example where this is a problem please? I can't find any having this issue... |
|
Pretty much any section:
Here you can see there's a gap between the elements: It doesn't seem to happen on Chrome, but Firefox and Safari seem to suffer from it. Different engines seem to treat the en-space differently. I'm not sure what the en-space is trying to accomplish, actually. If it is trying to extend the hover region, I think using padding would be more reliable. |
|
Ok tested and with your changes, smaller titles work but |
|
Hm, that's strange.
The purple region is the padding, which should count for hovering. I made it a little extra wide so that it is sure to overlap. I'm not sure what you mean by "titles". Is that like headers like "Examples"? Those also seem ok:
|
|
Now it's good, might have failed to update the CSS... Thanks a lot! @bors: r+ rollup |
|
📌 Commit 1c888d5 has been approved by |
bors
added
S-waiting-on-bors
…llaumeGomez rustdoc: Fix gap on section anchor symbol when hovering. Fixes rust-lang#49485 for section headings.
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
Fixes #49485 for section headings.