Rollup of 5 pull requests #53717
Merged
Rollup of 5 pull requests #53717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Doing the expansion on onhashchange seems too late. Fixes rust-lang#48726
Fixes rust-lang#49485 for section headings.
…-display, r=QuietMisdreavus Improve unstable message display Fixes rust-lang#51387. Reopening of rust-lang#51563. New display: <img width="1440" alt="screen shot 2018-08-04 at 00 01 39" src="https://user-images.githubusercontent.com/3050060/43667793-dc14f708-9779-11e8-9808-f3ff126fc213.png"> r? @QuietMisdreavus
libtest terse format: show how far in we are So for example `./x.py test src/libcore` looks like ``` running 881 tests .................................................................................................... 100/881 .................................................................................................... 200/881 .................................................................................................... 300/881 .............................................................i.i.................................... 400/881 .................................................................................................... 500/881 .................................................................................................... 600/881 .................................................................................................... 700/881 .................................................................................................... 800/881 ................................................................................. test result: ok. 879 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out ``` When I am waiting for 3500 ui tests to complete, I am often missing some sense of how far in these 3500 it is. Getting the total count in `write_run_start` is a bit hacky; I did that to not change the "public interface" of the formatters. I can also give them an extra argument in their constructor so that they know from the beginning how many tests there will be. Would you prefer that? (I think I would, but I wanted to get feedback first.)
Automatically expand a section even after page load Fixes rust-lang#52774
…ietMisdreavus Add struct keyword doc Slowly, one keyword at a time. r? @QuietMisdreavus
…llaumeGomez rustdoc: Fix gap on section anchor symbol when hovering. Fixes rust-lang#49485 for section headings.
|
@bors: r+ p=5 |
|
📌 Commit f9eef71 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 26, 2018
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Aug 26, 2018
Rollup of 5 pull requests Successful merges: - #53043 (Improve unstable message display) - #53428 (libtest terse format: show how far in we are) - #53626 (Automatically expand a section even after page load) - #53651 (Add struct keyword doc) - #53706 (rustdoc: Fix gap on section anchor symbol when hovering.) Failed merges: - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) r? @ghost
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Failed merges:
r? @ghost