Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a typo in core::convert::AsMut #61382

Merged
merged 1 commit into from
Jun 1, 2019
Merged

Fixed a typo in core::convert::AsMut #61382

merged 1 commit into from
Jun 1, 2019

Conversation

OptimisticPeach
Copy link
Contributor

Just missing a space, and added a comma to make more idiomatic.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Kimundi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@OptimisticPeach
Copy link
Contributor Author

Following the contribution instructions,

r? @steveklabnik

@Centril
Copy link
Contributor

Centril commented May 31, 2019

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2019

📌 Commit fc21f33 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2019
@Centril
Copy link
Contributor

Centril commented May 31, 2019

r? @Centril

@czipperz
Copy link
Contributor

czipperz commented May 31, 2019

Side conversation: I thought there was an RFC that said the assignment would happen automatically from now on. Has that not been implemented yet?

@jonas-schievink
Copy link
Contributor

@czipperz I'm assuming you're talking about #59489? That's not yet implemented; it is being tracked in rust-lang/homu#43

pietroalbini added a commit to pietroalbini/rust that referenced this pull request May 31, 2019
Fixed a typo in core::convert::AsMut

Just missing a space, and added a comma to make more idiomatic.
bors added a commit that referenced this pull request Jun 1, 2019
Rollup of 11 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)
 - #61382 (Fixed a typo in core::convert::AsMut)

Failed merges:

r? @ghost
@bors bors merged commit fc21f33 into rust-lang:master Jun 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants