Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate some books to mdbook version 0.2 #61372

Merged
merged 3 commits into from
Jun 1, 2019
Merged

Conversation

mati865
Copy link
Contributor

@mati865 mati865 commented May 30, 2019

There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.

@rust-highfive
Copy link
Collaborator

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 30, 2019
@mati865
Copy link
Contributor Author

mati865 commented May 30, 2019

r? @GuillaumeGomez

@Centril
Copy link
Contributor

Centril commented May 30, 2019

@bors rollup

@GuillaumeGomez
Copy link
Member

Thanks!

@bors: r=Centril,GuillaumeGomez

@bors
Copy link
Contributor

bors commented May 30, 2019

📌 Commit dacf19c has been approved by Centril,GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 30, 2019
Centril added a commit to Centril/rust that referenced this pull request May 30, 2019
…omez

Migrate some books to mdbook version 0.2

There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.
@ehuss
Copy link
Contributor

ehuss commented May 30, 2019

Just for some context, the reference and cargo books are blocked on getting a new mdbook release made. Still trying to get ownership on crates.io to do that. Hopefully will be able to remove the mdbook1 stuff soon!

@mati865
Copy link
Contributor Author

mati865 commented May 30, 2019

Thanks for the info!
I think rustc book may be blocked on reference migration (gave me odd errors but I haven't investigated it deeply). Rust-by-example should be doable.

Hopefully will be able to remove the mdbook1 stuff soon!

I hoped to get rid of it this/next week but looks like I'll have to be patient.

bors added a commit that referenced this pull request May 31, 2019
Rollup of 10 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61278 (Miri: give machine the chance to tag all allocations)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)

Failed merges:

r? @ghost
pietroalbini added a commit to pietroalbini/rust that referenced this pull request May 31, 2019
…omez

Migrate some books to mdbook version 0.2

There are 3 books still using old version but they need more effort so I hope to do them in subsequent PR if I find the time.
bors added a commit that referenced this pull request Jun 1, 2019
Rollup of 11 pull requests

Successful merges:

 - #60897 (error: remove StringError from Debug output)
 - #61304 (Speed up Azure CI installing Windows dependencies)
 - #61319 (Swap order of `unsafe async fn` to `async unsafe fn`)
 - #61342 (Set ellipsis_inclusive_range_patterns lint to warn)
 - #61344 (Add regression test for const generics ICE)
 - #61359 (Fix links in Deref documentation)
 - #61363 (Stabilize iter_nth_back feature)
 - #61369 (Fixed lifetime misspelling)
 - #61372 (Migrate some books to mdbook version 0.2)
 - #61374 (Explicitly suggest 'type_ascription' feature)
 - #61382 (Fixed a typo in core::convert::AsMut)

Failed merges:

r? @ghost
@bors bors merged commit dacf19c into rust-lang:master Jun 1, 2019
@mati865 mati865 deleted the books branch June 1, 2019 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants