Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 18 pull requests #76414

Closed
wants to merge 41 commits into from

Commits on Aug 13, 2020

  1. Add Atomic*::from_mut.

    The atomic equivalent of Cell::from_mut.
    m-ou-se committed Aug 13, 2020
    Configuration menu
    Copy the full SHA
    fcf1571 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    09fff5f View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2020

  1. Configuration menu
    Copy the full SHA
    8142457 View commit details
    Browse the repository at this point in the history

Commits on Sep 3, 2020

  1. Add missing link in README

    camelid committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    8783c62 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3e29fdb View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    791f93c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    2278c72 View commit details
    Browse the repository at this point in the history
  5. Make Ipv4Addr and Ipv6Addr const tests unit tests under library

    These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
    CDirkx committed Sep 3, 2020
    Configuration menu
    Copy the full SHA
    a2e077e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    8c93125 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7b823df View commit details
    Browse the repository at this point in the history

Commits on Sep 4, 2020

  1. Move various ui const tests to library

    Move:
     - `src\test\ui\consts\const-nonzero.rs` to `library\core`
     - `src\test\ui\consts\ascii.rs` to `library\core`
     - `src\test\ui\consts\cow-is-borrowed` to `library\alloc`
    
    Part of rust-lang#76268
    CDirkx committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    538e198 View commit details
    Browse the repository at this point in the history
  2. Remove a useless allowed attr

    tesuji committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    a3ee65f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8f11127 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fac2726 View commit details
    Browse the repository at this point in the history
  5. Move Vec slice UI tests in library

    Ayush Kumar Mishra committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    d16bbd1 View commit details
    Browse the repository at this point in the history
  6. Implementation of incompatible features error

    If two features are defined as incompatible, using them together would
    result in an error
    Amjad50 committed Sep 4, 2020
    Configuration menu
    Copy the full SHA
    8f2d906 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2ed1a21 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    59e3733 View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2020

  1. Indent a note to make folding work nicer

    Co-authored-by: Joshua Nelson <joshua@yottadb.com>
    tesuji and Joshua Nelson committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    dfd219d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7cc2569 View commit details
    Browse the repository at this point in the history
  3. Improve the documentation of filter() and filter_map().

    I believe the documentation is currently a little misleading.
    
    For example, in the docs for `filter()`:
    
    > If the closure returns `false`, it will try again, and call the closure on
    > the next element, seeing if it passes the test.
    
    This kind of implies that if the closure returns true then we *don't* "try
    again" and no further elements are considered. In actuality that's not the
    case, every element is tried regardless of what happened with the previous
    element.
    
    This change tries to clarify that by removing the uses of "try again"
    altogether.
    vext01 committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    8af85fa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    7cbfbd3 View commit details
    Browse the repository at this point in the history
  5. debuginfo: Ignore HashMap tests before cdb 10.0.18362.1

    cdb chokes on the cast and reports "Unable to find type 'tuple<u64,u64> *' for cast."
    MaulingMonkey committed Sep 5, 2020
    Configuration menu
    Copy the full SHA
    4046f92 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2020

  1. Rollup merge of rust-lang#74532 - fusion-engineering-forks:atomic-fro…

    …m-mut, r=KodrAus
    
    Add Atomic*::from_mut.
    
    The atomic equivalent of [`Cell::from_mut`](https://doc.rust-lang.org/stable/std/cell/struct.Cell.html#method.from_mut).
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    099af05 View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#75949 - vext01:filter-docs, r=jyn514

    Try to improve the documentation of `filter()` and `filter_map()`.
    
    I believe the documentation is currently a little misleading.
    
    For example, in the docs for `filter()`:
    
    > If the closure returns `false`, it will try again, and call the closure on
    > the next element, seeing if it passes the test.
    
    This kind of implies that if the closure returns true then we *don't* "try
    again" and no further elements are considered. In actuality that's not the
    case, every element is tried regardless of what happened with the previous
    element.
    
    This change tries to clarify that by removing the uses of "try again"
    altogether.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    8abb528 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#76157 - ArekPiekarz:const_caller_location_t…

    …racking_issue, r=joshtriplett
    
    Update tracking issue for const_caller_location
    
    Update the tracking issue to rust-lang#76156, as suggested in rust-lang#76105.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    bdd3b05 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#76229 - camelid:patch-3, r=jonas-schievink

    Add missing link in README
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    de3e0a6 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#76273 - CraftSpider:master, r=matklad

    Move some Vec UI tests into alloc unit tests
    
    A bit of work towards rust-lang#76268, makes a number of the Vec UI tests that are simply running code into unit tests. Ensured that they are being run when testing liballoc locally.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    26b67dd View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#76274 - scottmcm:fix-76271, r=petrochenkov

    Allow try blocks as the argument to return expressions
    
    Fixes rust-lang#76271
    
    I don't think this needs to be edition-aware (phew) since `return try` in 2015 is also the start of an expression, just with a struct literal instead of a block (`return try { x: 4, y: 5 }`).
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    3e0a83c View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#76287 - lzutao:rm-allowed, r=jyn514

    Remove an unnecessary allowed lint
    
    It is outdated.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    5d24dd0 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#76293 - Amjad50:incompatible_features_error…

    …, r=lcnr
    
    Implementation of incompatible features error
    
    Proposal of a new error: Incompatible features
    
    This error should happen if two features which are not compatible are used together.
    
    For now the only incompatible features are `const_generics` and `min_const_generics`
    
    fixes rust-lang#76280
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    a979810 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#76299 - CDirkx:ip-tests, r=matklad

    Make `Ipv4Addr` and `Ipv6Addr` const tests unit tests under `library`
    
    These tests are about the standard library, not the compiler itself, thus should live in `library`, see rust-lang#76268.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    2d5f21d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#76302 - jyn514:peekable-2, r=Dylan-DPC

    Address review comments on `Peekable::next_if`
    
    r? @pickfire
    See rust-lang#72310 (review) for context.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    f06c59e View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#76303 - jyn514:vec-assert-doc, r=Dylan-DPC

    Link to `#capacity-and-reallocation` when using with_capacity
    
    Follow up to rust-lang#76058 (comment).
    r? @pickfire
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    7d9d348 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#76305 - CDirkx:const-tests, r=matklad

    Move various ui const tests to `library`
    
    Move:
     - `src\test\ui\consts\const-nonzero.rs` to `library\core`
     - `src\test\ui\consts\ascii.rs` to `library\core`
     - `src\test\ui\consts\cow-is-borrowed` to `library\alloc`
    
    Part of rust-lang#76268
    
    r? @matklad
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    bdd9561 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#76309 - lzutao:indent-note, r=jyn514

    Indent a note to make folding work nicer
    
    Sublime Text folds code based on indentation. It maybe an unnecessary change, but does it look nicer after that ?
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    4782725 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#76312 - numbermaniac:patch-1, r=shepmaster

    time.rs: Make spelling of "Darwin" consistent
    
    On line 89 of this file, the OS name is written as "Darwin", but on line 162 it is written in all-caps. Darwin is usually spelt as a standard proper noun, i.e. "Darwin", rather than in all-caps.
    
    This change makes that form consistent in both places.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    eb02832 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#76318 - scottmcm:one-control-flow, r=ecstat…

    …ic-morse
    
    Use ops::ControlFlow in rustc_data_structures::graph::iterate
    
    Since I only know about this because you mentioned it,
    r? @ecstatic-morse
    
    If we're not supposed to use new `core` things in compiler for a while then feel free to close, but it felt reasonable to merge the two types since they're the same, and it might be convenient for people to use `?` in their traversal code.
    
    (This doesn't do the type parameter swap; NoraCodes has signed up to do that one.)
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    97cd85d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#76324 - ayushmishra2005:move_vec_tests_in_l…

    …ibrary, r=matklad
    
    Move Vec slice UI tests in library
    
    Moved some of Vec slice UI tests in Library as a part of rust-lang#76268
    
    r? @matklad
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    378274b View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#76338 - euclio:intra-link-iterator, r=jyn514

    add some intra-doc links to `Iterator`
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    d80185b View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#76390 - MaulingMonkey:pr-min-cdb-version, r…

    …=petrochenkov
    
    debuginfo:  Ignore HashMap .natvis tests before cdb 10.0.18362.1
    
    CDB <10.0.18362.1 chokes on casts within HashMap's natvis visualizers.  This PR adds support for "min-cdb-version" (per existing "min-gdb-version" and "min-lldb-version" filters) and uses it.  CI uses a more recent version of CDB for testing and thus should still run the tests.
    
    Credit to @petrochenkov per rust-lang#76352 for helping catch this.
    
    ### SDK Testing
    
    | Win 10 SDK                                                             |  x64 CDB          | rustc 1.47.0-nightly (bf43421 2020-08-25) built-in .natvis  | Note |
    | --------------------------------------------------------------------- | ----------------- | ------------------------------------------------------------- | ---- |
    | [10.0.19041.0](https://go.microsoft.com/fwlink/p/?linkid=2120843)     | 10.0.19041.1      | ✔️                                                            | CI
    | [10.0.18362.1](https://go.microsoft.com/fwlink/?linkid=2083338)       | 10.0.18362.1      | ✔️                                                            | MaulingMonkey
    | [10.0.17763.0](https://go.microsoft.com/fwlink/p/?LinkID=2033908)     | 10.0.17763.132    | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.`
    | [10.0.17134.12](https://go.microsoft.com/fwlink/p/?linkid=870807)     | 10.0.17134.12     | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.`
    | [10.0.16299.91](https://go.microsoft.com/fwlink/p/?linkid=864422)     | 10.0.16299.91     | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.`
    | [10.0.15063.468](https://go.microsoft.com/fwlink/p/?LinkId=845298)    | 10.0.15063.468    | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.`
    | [10.0.14393.795](https://go.microsoft.com/fwlink/p/?LinkId=838916)    | 10.0.14321.1024   | ❌ `Unable to find type 'tuple<u64,u64> *' for cast.` | petrochenkov
    | [10.0.10586.212](https://go.microsoft.com/fwlink/p/?LinkID=698771)    | 10.0.10586.567    | ❌ `Expected ')' at '+ 1)].__1'`
    | [10.0.10240](https://go.microsoft.com/fwlink/p/?LinkId=619296)        | 10.0.10240?       | ❔ Untested
    
    ### Rust Testing
    
    ```cmd
    x.py test --stage 1 src/tools/tidy
    x.py test --stage 1 --build x86_64-pc-windows-msvc src\test\debuginfo
    ```
    
    Also verified test still fails when intentionally broken w/ CDB version >= min-cdb-version.
    Dylan-DPC authored Sep 6, 2020
    Configuration menu
    Copy the full SHA
    caaf743 View commit details
    Browse the repository at this point in the history