Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to run a specific rustdoc-js* test #90613

Merged
merged 1 commit into from
Nov 9, 2021

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Nov 5, 2021
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 5, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the specific-rustdoc-js-test branch from a765afd to 51e23a2 Compare November 9, 2021 11:05
@GuillaumeGomez
Copy link
Member Author

@Mark-Simulacrum Thanks for the suggestion! Thanks to it, I was able to clean another test-suite argument as well.

@GuillaumeGomez
Copy link
Member Author

Added a panic in case the file extension wasn't the expected one.

@rust-log-analyzer

This comment has been minimized.

@GuillaumeGomez GuillaumeGomez force-pushed the specific-rustdoc-js-test branch from dc65233 to 366031a Compare November 9, 2021 14:37
@Mark-Simulacrum
Copy link
Member

r=me with commits squashed

Thanks!

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2021
@GuillaumeGomez GuillaumeGomez force-pushed the specific-rustdoc-js-test branch from 366031a to 10d65a9 Compare November 9, 2021 16:42
@GuillaumeGomez
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Nov 9, 2021

📌 Commit 10d65a9 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2021
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2021
…test, r=Mark-Simulacrum

Allow to run a specific rustdoc-js* test

r? `@Mark-Simulacrum`
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 9, 2021
…askrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#89561 (Type inference for inline consts)
 - rust-lang#90035 (implement rfc-2528 type_changing-struct-update)
 - rust-lang#90613 (Allow to run a specific rustdoc-js* test)
 - rust-lang#90683 (Make `compiler-docs` only control the default instead of being a hard off-switch)
 - rust-lang#90685 (x.py: remove fixme by deleting code)
 - rust-lang#90701 (Record more artifact sizes during self-profiling.)
 - rust-lang#90723 (Better document `Box` and `alloc::alloc::box_free` connection)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 730c6bf into rust-lang:master Nov 9, 2021
@rustbot rustbot added this to the 1.58.0 milestone Nov 9, 2021
@GuillaumeGomez GuillaumeGomez deleted the specific-rustdoc-js-test branch November 10, 2021 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants