Record more artifact sizes during self-profiling. #90701
Conversation
|
r? @davidtwco (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@rylev, did I forget any artifact kind we talked about? |
|
@michaelwoerister Totally missed the first bullet point. Looks good! |
There was a problem hiding this comment.
Currently the identifiers emitted for these are hard-coded as string literals. Is it worth adding constants to https://github.com/rust-lang/measureme/blob/master/measureme/src/rustc.rs instead? We don't do that for query names and the like -- but artifact kinds might be more stable than query names.
I don't think it would hurt, if you want to do this, feel free, don't think it's strictly necessary, within the compiler each of these constants would probably only be used once? r=me regardless.
Yes they would only be used once in the compiler. However, it would be useful for keeping the compiler and measureme-based tooling in sync. I opened rust-lang/measureme#191 so we don't forget. But it's not worth doing a new measureme release for that, I'd say. Thanks for the reviews, @davidtwco & @rylev! @bors r=davidtwco |
|
📌 Commit fefe1e9 has been approved by |
bors
added
S-waiting-on-bors
…s, r=davidtwco Record more artifact sizes during self-profiling. This PR adds artifact size recording for - "linked artifacts" (executables, RLIBs, dylibs, static libs) - object files - dwo files - assembly files - crate metadata - LLVM bitcode files - LLVM IR files - codegen unit size estimates Currently the identifiers emitted for these are hard-coded as string literals. Is it worth adding constants to https://github.com/rust-lang/measureme/blob/master/measureme/src/rustc.rs instead? We don't do that for query names and the like -- but artifact kinds might be more stable than query names.
…askrgr Rollup of 7 pull requests Successful merges: - rust-lang#89561 (Type inference for inline consts) - rust-lang#90035 (implement rfc-2528 type_changing-struct-update) - rust-lang#90613 (Allow to run a specific rustdoc-js* test) - rust-lang#90683 (Make `compiler-docs` only control the default instead of being a hard off-switch) - rust-lang#90685 (x.py: remove fixme by deleting code) - rust-lang#90701 (Record more artifact sizes during self-profiling.) - rust-lang#90723 (Better document `Box` and `alloc::alloc::box_free` connection) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
This PR adds artifact size recording for
Currently the identifiers emitted for these are hard-coded as string literals. Is it worth adding constants to https://github.com/rust-lang/measureme/blob/master/measureme/src/rustc.rs instead? We don't do that for query names and the like -- but artifact kinds might be more stable than query names.