Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[save-analysis] Reference the variant not enum at struct-literal cons… #96986

Merged
merged 1 commit into from
May 14, 2022
Merged

[save-analysis] Reference the variant not enum at struct-literal cons… #96986

merged 1 commit into from
May 14, 2022

Conversation

kdashg
Copy link
Contributor

@kdashg kdashg commented May 12, 2022

…truction.

Closes #96985

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 12, 2022
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @oli-obk (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2022
est31
est31 reviewed May 12, 2022
View reviewed changes
Copy link
Member

@est31 est31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't checked yet, but it's likely that this fixes warnalyzer's issues with it not recognizing struct enum variant constructions. Very big thank you in any case!

compiler/rustc_save_analysis/src/dump_visitor.rs Outdated Show resolved Hide resolved
@oli-obk
Copy link
Contributor

oli-obk commented May 13, 2022

I'm going to trust you two know what you're talking about. The diff makes sense to me, but I don't even know which active contributor to ping for save analysis things.

@bors r+

@bors
Copy link
Contributor

bors commented May 13, 2022

📌 Commit 5fde765 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2022
@JohnTitor JohnTitor mentioned this pull request May 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
@bors
Auto merge of rust-lang#97035 - JohnTitor:rollup-00ko07z, r=JohnTitor
c318799 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95365 (Use default alloc_error_handler for hermit)
 - rust-lang#96986 ([save-analysis] Reference the variant not enum at struct-literal cons…)
 - rust-lang#96998 (rustdoc: remove weird, unused variable from source-files.js)
 - rust-lang#97005 (Two small improvements of rustc_expand)
 - rust-lang#97018 (Ensure that test fail if a JS error occurs)
 - rust-lang#97031 (Drop tracking: handle invalid assignments better)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit c031413 into rust-lang:master May 14, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@est31 est31 est31 left review comments

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.

rustc save-analysis records variant struct-literal spans as referencing enum not variant
6 participants
@kdashg @rust-highfive @oli-obk @bors @est31 @rustbot