Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: remove weird, unused variable from source-files.js #96998

Merged
merged 1 commit into from
May 14, 2022
Merged

rustdoc: remove weird, unused variable from source-files.js #96998

merged 1 commit into from
May 14, 2022

Conversation

notriddle
Copy link
Contributor

No description provided.

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 13, 2022
@rust-highfive
Copy link
Collaborator

r? @jsha

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2022
@notriddle
Copy link
Contributor Author

r? @GuillaumeGomez

@rust-highfive rust-highfive assigned GuillaumeGomez and unassigned jsha May 13, 2022
@jsha
Copy link
Contributor

jsha commented May 13, 2022

@bors r+ rollup

Looks like this was first introduced to encourage a minifier to use N instead of null, but I agree we don't use it now. 115df57

@bors
Copy link
Contributor

bors commented May 13, 2022

📌 Commit 1b41d11 has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2022
@JohnTitor JohnTitor mentioned this pull request May 14, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
@bors
Auto merge of rust-lang#97035 - JohnTitor:rollup-00ko07z, r=JohnTitor
c318799 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95365 (Use default alloc_error_handler for hermit)
 - rust-lang#96986 ([save-analysis] Reference the variant not enum at struct-literal cons…)
 - rust-lang#96998 (rustdoc: remove weird, unused variable from source-files.js)
 - rust-lang#97005 (Two small improvements of rustc_expand)
 - rust-lang#97018 (Ensure that test fail if a JS error occurs)
 - rust-lang#97031 (Drop tracking: handle invalid assignments better)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 93a4dfd into rust-lang:master May 14, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 14, 2022
@notriddle notriddle deleted the notriddle/var-N branch May 14, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.62.0
Development

Successfully merging this pull request may close these issues.
6 participants
@notriddle @rust-highfive @jsha @bors @GuillaumeGomez @rustbot