Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that test fail if a JS error occurs #97018

Merged
merged 2 commits into from
May 14, 2022

Conversation

GuillaumeGomez
Copy link
Member

Fixes #96902.

r? @notriddle

@GuillaumeGomez GuillaumeGomez added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 13, 2022
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 13, 2022
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 13, 2022

📌 Commit 5ec5a76 has been approved by notriddle

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 13, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 14, 2022
Rollup of 6 pull requests

Successful merges:

 - rust-lang#95365 (Use default alloc_error_handler for hermit)
 - rust-lang#96986 ([save-analysis] Reference the variant not enum at struct-literal cons…)
 - rust-lang#96998 (rustdoc: remove weird, unused variable from source-files.js)
 - rust-lang#97005 (Two small improvements of rustc_expand)
 - rust-lang#97018 (Ensure that test fail if a JS error occurs)
 - rust-lang#97031 (Drop tracking: handle invalid assignments better)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ec14d94 into rust-lang:master May 14, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 14, 2022
@GuillaumeGomez GuillaumeGomez deleted the fail-on-js-error branch May 14, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustdoc GUI tests should check for JS errors
5 participants