Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

downloadonly vs download_only #54790

Closed
brejoc opened this issue Sep 27, 2019 · 3 comments · Fixed by #55448
Closed

downloadonly vs download_only #54790

brejoc opened this issue Sep 27, 2019 · 3 comments · Fixed by #55448
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE fixed-pls-verify fix is linked, bug author to confirm fix v2019.2.1 unsupported version
Milestone
Approved

Comments

@brejoc
Copy link
Contributor

brejoc commented Sep 27, 2019

Description of Issue

This merged PR clashes with the downloadonly parameter we already had for the yum and zypper module. The parameter should be downloadonly and not download_only.

Versions Report

Salt >= 2017.7.0.
@brejoc
Copy link
Contributor Author

brejoc commented Sep 27, 2019 •
edited
Loading

I'd suggest to also support downloadonly as an attribute in aptpkg.py to not break any existing code and deprecate download_only in some of the future releases.

Is it possible to get this into 2019.2.1 as a bugfix?

@brejoc brejoc mentioned this issue Sep 27, 2019
Closed
@brejoc
Copy link
Contributor Author

brejoc commented Sep 27, 2019

I've just opened a draft for the change I had in mind.

@cmcmarrow cmcmarrow added Bug broken, incorrect, or confusing behavior v2019.2 unsupported version v2019.2.1 unsupported version fixed-pls-verify fix is linked, bug author to confirm fix and removed v2019.2 unsupported version labels Sep 27, 2019
@cmcmarrow cmcmarrow added this to the Approved milestone Sep 27, 2019
@cmcmarrow
Copy link
Contributor

Thanks

@cmcmarrow cmcmarrow added the Confirmed Salt engineer has confirmed bug/feature - often including a MCVE label Sep 27, 2019
cbosdo pushed a commit to cbosdo/salt that referenced this issue Nov 26, 2019
@brejoc
Adds the possibility to also use downloadonly in kwargs
f9e7ace 
The download_only parameter in the apt module is not in line with
the yum and zypper modules. Both of them use downloadonly without
the underline.

With this change apt now additionally supports the downloadonly
parameter.

Fixes saltstack#54790
@brejoc brejoc mentioned this issue Nov 27, 2019
Merged
admd pushed a commit to admd/salt-1 that referenced this issue Jan 27, 2020
@brejoc
Adds the possibility to also use downloadonly in kwargs
72f77bd 
The download_only parameter in the apt module is not in line with
the yum and zypper modules. Both of them use downloadonly without
the underline.

With this change apt now additionally supports the downloadonly
parameter.

Fixes saltstack#54790
agraul pushed a commit to agraul/salt that referenced this issue Apr 22, 2020
@brejoc
Adds the possibility to also use downloadonly in kwargs
39ab885 
The download_only parameter in the apt module is not in line with
the yum and zypper modules. Both of them use downloadonly without
the underline.

With this change apt now additionally supports the downloadonly
parameter.

Fixes saltstack#54790
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug broken, incorrect, or confusing behavior Confirmed Salt engineer has confirmed bug/feature - often including a MCVE fixed-pls-verify fix is linked, bug author to confirm fix v2019.2.1 unsupported version
Projects
None yet
Milestone
Approved
Development

Successfully merging a pull request may close this issue.

Adds the possibility to also use downloadonly in kwargs
2 participants
@brejoc @cmcmarrow