Adds the possibility to also use downloadonly in kwargs #55448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download_only parameter in the apt module is not in line with the yum and zypper modules. Both of them use downloadonly without the underline. With this change apt now additionally supports the downloadonly parameter. Fixes #54790
This will be cleaned up later.
… and removal of debug prints
ghost
requested a review
from 
brejoc
changed the title
Akm0d
approved these changes
Nov 27, 2019
dwoz
approved these changes
Dec 2, 2019
twangboy
approved these changes
Dec 2, 2019
Akm0d
reviewed
Dec 2, 2019
| @@ -1048,7 +1049,7 @@ def upgrade(refresh=True, dist_upgrade=False, **kwargs): | |||
| cmd.append('--force-yes') | |||
| if kwargs.get('skip_verify', False): | |||
| cmd.append('--allow-unauthenticated') | |||
| if kwargs.get('download_only', False): | |||
| if kwargs.get('download_only', False) or kwargs.get('downloadonly', False): | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is the same as #54793, but for master.
The download_only parameter in the apt module is not in line with the yum and zypper modules. Both of them use downloadonly without the underline.
With this change apt now additionally supports the downloadonly parameter.
What issues does this PR fix or reference?
Fixes #54790
Previous Behavior
The apt module had to be used with
download_only.New Behavior
The apt module can now also be used with
downloadonly.Tests written?
Yes
Commits signed with GPG?
Yes