-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds the possibility to also use downloadonly in kwargs #54793
Conversation
The download_only parameter in the apt module is not in line with the yum and zypper modules. Both of them use downloadonly without the underline. With this change apt now additionally supports the downloadonly parameter. Fixes #54790
|
Thanks you for the test and keeping backwards compatibility in mind. |
@brejoc The |
…to 2019.2.1_downloadonly-fix
This will be cleaned up later.
This is really strange. Locally the tests are passing and I can see the download-only parameter in the args list. But when run here, the args are just empty:
|
… and removal of debug prints
@dwoz looks like this is good to go now. Would it make sense to rebase to master? |
@saltstack/core-pr-reviewers Would it make more sense to close this and open an other PR with these changes against master? |
What does this PR do?
The download_only parameter in the apt module is not in line with the yum and zypper modules. Both of them use downloadonly without the underline.
With this change apt now additionally supports the downloadonly parameter.
What issues does this PR fix or reference?
Fixes #54790
Previous Behavior
The apt module had to be used with
download_only
.New Behavior
The apt module can now also be used with
downloadonly
.Tests written?
Yes
Commits signed with GPG?
Yes