Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Favor Hyrax.query_service over method chaining #6671

Merged
merged 1 commit into from
Feb 7, 2024

Commits on Feb 6, 2024

  1. ♻️ Favor Hyrax.query_service over method chaining

    Prior to this commit we relied on the access_control object to "self
    convert" via the `#valkyrie_resource` method.  However, that method
    circumvents the `Hyrax.query_service` which provides a more up to date
    version of the permissions.
    
    This is subtle bug is most notable when we have composite adapters;
    those modeled in the `double_combo` branch.
    
    How it manifests is as follows:
    
    - I have a Work and ACL in Fedora.
    - I update the ACL to Postgres.
      - When I fetch the Work, it's in Fedora and grabs the ACL from Fedora
        which is not the most current.
    
    This relates to:
    
    - 0de7df6
    - #6670
    jeremyf committed Feb 6, 2024
    Configuration menu
    Copy the full SHA
    f0e99c5 View commit details
    Browse the repository at this point in the history