Merge and enable feature.use 🎉 #835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge master into feature.use
Merge master into feature.use
Add load-css()
Merge origin/master into feature.use
Merge master into feature.use
Merge master into feature.use
Merge master into feature.use
We had been using null to represent an empty configuration, but that caused problems when an empty map snuck its way in as well. Now we always use maps, with a const empty map for the common case. See sass/sass#2744
nshahan
approved these changes
Oct 1, 2019
| migrate your stylesheets to the new module system! | ||
|
|
||
| [migrator blog]: https://sass-lang.com/blog/7858341-the-module-system-is-launched | ||
| [Sass migrator]: https://sass-lang.com/documentation/cli/migrator |
There was a problem hiding this comment.
Just want to warn you that the link for the migrator isn't live yet.
dart_test.yaml
Outdated
Comment on lines
5
to
8
| # Indicates tests that use the new module system, and so should only run on | ||
| # the `feature.use` branch. | ||
| module-system: | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #554
See sass/sass-spec#1468