Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge and enable feature.use 🎉 #1468

Merged
merged 60 commits into from
Oct 1, 2019
Merged

Merge and enable feature.use 🎉 #1468

merged 60 commits into from
Oct 1, 2019

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Oct 1, 2019 •
edited
Loading

See sass/sass#1094

[skip dart-sass]

@nex3
Run tests on feature branches
10d13c7
@nex3
Run against Dart Sass's feature.use branch
708c5fe
@nex3
Add @use syntax error tests
3d8e447
@nex3
Update a non-@use test for a new parsing error
523fe18 
This is caused because "identifier." is now expected to be followed by
another identifier, rather than being parsed as a number.
@nex3
Update specs for a better ordering error message
c70d500 
Also add specs for nesting @use within other rules
@nex3
Merge pull request #1341 from sass/use.syntax
abeaff3 
Add @use syntax error tests
@nex3
Merge branch 'master' into 'feature.use'
831bd56
@nex3
Add @import specs for @import-only files
821bd8a
@nex3
Update Dart Sass error messages for @use
1bff139
@nex3
Add specs for @use errors
8359a83
@nex3
Add specs for member usage with @use
e0df66b
@nex3
Add specs for core functions interacting with modules
f74c74c
@nex3
Merge pull request #1349 from sass/use-members
491a7a6 
Add @use member usage and load error tests
@nex3
Make .scss and .sass take precedence over .css in @use (#1350)
2c3d64b 
See sass/sass#68
@nex3
Add specs for loading files with @use
f5285d0
@nex3
Merge branch 'master' into feature.use
117e3e0
@nex3
Add specs for CSS ordering with @use
e04fcec
@nex3
Merge pull request #1357 from sass/use.css
fec05ad 
Add partial specs for loading CSS with @use
@nex3
Merge pull request #1356 from sass/merge-master
9b1a9e2 
Merge branch 'master' into feature.use
@nex3
Add @extend tests for @use (#1359)
3a91c3b
@nex3
Split CSS specs out from load specs
b30eddd
@nex3
Add specs for @use interacting with @import
0d9dc70
@nex3
Merge pull request #1367 from sass/use.import
61ee037 
Add specs for @use interacting with @import
@nex3
Add a spec for @extend being isolated to a single @use (#1368)
3e25ad9
@nex3
Merge branch 'master' into feature.use
43dc909
@nex3
Merge pull request #1389 from sass/merge-master
987a66e 
Merge master into feature.use
@nex3
Fix weird and unhelpful @use stack traces (#1392)
a6ddf69
@nex3
Add specs for @forward (#1393)
e980469 
See sass/sass#1094
@nex3
Add specs for built-in modules (#1400)
60ea8a3 
This does not include specs for functions that are newly defined as
part of the module system spec.
@nex3
Merge remote-tracking branch 'origin/master' into feature.use
00eff57
nex3 added 25 commits June 18, 2019 12:04
@nex3
Add specs for the module-variables() function
62b539b
@nex3
Materialize parent HRX directories if necessary
be7b493 
We just straightforwardly look for "../"s in files to determine if
they reach outside the directory being materialized.
@nex3
Add specs for the module-functions() function
6f01419
@nex3
Merge pull request #1403 from sass/new-functions
38d6195 
Add specs for module-variables() and module-functions()
@nex3
Produce better stack traces for syntax errors loaded via import/use (#…
69252ac 
…1404)

Instead of using "root stylesheet" as the member name for the loaded
files, this now uses "@import" or "@use".
@nex3
Add a spec for a nested import of a module that forwards a variable (#…
afc5acd 
…1413)
@nex3
Update specs with new behavior from Dart Sass's master branch (#1415)
88f14b9
@nex3
Add support for "@use with" (#1412)
cbe1fcb
@nex3
Add specs for load-css() (#1417)
e9b1764
@nex3
Merge remote-tracking branch 'origin/master' into feature.use
d0d1985
@nex3
Merge pull request #1436 from sass/merge-master
3a9889c 
Merge origin/master into feature.use
@nex3
Update specs for global member conflicts (#1435)
2919a8e
@nex3
Merge remote-tracking branch 'origin/master' into merge-master
12bc338
@nex3
Update specs for new variable messages and sass/sass#2726
c49b78b
@nex3
Merge pull request #1449 from sass/merge-master
395c249 
Merge master into feature.use
@nex3
Change the variable syntax to namespace.$name (#1459)
becf518 
See sass/sass#2731
@nex3
Add a regression test for sass/sass#2744
340805f
@nex3
Fix load-css() specs to allow an empty configuration
22f4ebf 
These specs were wrong. The proposal clearly indicates that empty
configurations mean a module is not being configured.
@nex3
Move the new spec to a better location and add a new one
d499df1
@nex3
Merge remote-tracking branch 'origin/master' into feature.use
701f077
@nex3
Merge pull request #1466 from sass/merge-master
544d0ab 
Merge master into feature.use
@nex3
Merge branch 'feature.use' into forward-and-use
ca0393d
@nex3
Merge pull request #1464 from sass/forward-and-use
8a55287 
Add a regression test for sass/sass#2744
@nex3
Remove adjust-hue() from sass:color (#1465)
a70b00d 
See sass/sass#2740
@nex3
Add a spec for multiple global uses in one file (#1467)
93c3f01 
See sass/dart-sass#832
@nex3 nex3 requested a review from nshahan October 1, 2019 21:25
@nex3 nex3 mentioned this pull request Oct 1, 2019
Merged
nshahan
nshahan approved these changes Oct 1, 2019
View reviewed changes
Copy link

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woohoo!

@nex3 nex3 merged commit 16a640b into master Oct 1, 2019
@nex3 nex3 deleted the merge-use branch October 1, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nex3 @nshahan