Remove Dart Sass TODOs for function specs #1424

nex3 · 2019-07-03T00:38:44Z

[skip dart-sass]

nshahan

Awesome to see these todos get cleaned up!

nex3 requested a review from nshahan July 3, 2019 00:38

nex3 mentioned this pull request Jul 3, 2019

Fix a bunch of small spec incompatibilities in built-in functions sass/dart-sass#750

Merged

nex3 force-pushed the dart-sass-fixes branch from 0f9c9fa to d2642c7 Compare July 3, 2019 21:20

nshahan approved these changes Jul 3, 2019

View reviewed changes

nex3 added 11 commits July 3, 2019 15:34

Update Dart Sass specs for saturate()

e65c52a

See sass/dart-sass#699

Update Dart Sass specs for alpha()

57e60b0

See sass/dart-sass#700

Update Dart Sass spec for invert(..., 50%)

1394c0b

See sass/dart-sass#704

Update Dart Sass spec for plain-CSS invert() with a weight

c9dd1e4

See sass/dart-sass#705

Update Dart Sass spec for adjust-color() with $hue and $alpha

7313393

See sass/dart-sass#708

Update Dart Sass spec for str-slice() with astral plane characters

57e2a05

See sass/dart-sass#732

Update Dart Sass spec for str-insert() with $index -1

43d1a4d

See sass/dart-sass#733

Update Dart Sass specs for empty map separators

ae26bc0

See sass/dart-sass#737

Update Dart Sass specs for join() and append() $separator errors

ef647e9

See sass/dart-sass#738

Update Dart Sass spec for zip() with no arguments

5951337

See sass/dart-sass#739

Update Dart Sass spec for map-remove() with a named $key argument

27efe6f

See sass/dart-sass#742

nex3 force-pushed the dart-sass-fixes branch from d2642c7 to 27efe6f Compare July 3, 2019 22:34

nex3 merged commit d8dc38c into master Jul 4, 2019

nex3 deleted the dart-sass-fixes branch July 4, 2019 00:55

Provide feedback